-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow of
in await using
declarations in for-of loops
#55558
Merged
rbuckton
merged 3 commits into
microsoft:main
from
Andarist:fix/allow-of-in-await-using-in-for-of
Oct 31, 2023
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
tests/baselines/reference/awaitUsingDeclarationsInForAwaitOf.2.errors.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
awaitUsingDeclarationsInForAwaitOf.2.ts(4,7): error TS1431: 'for await' loops are only allowed at the top level of a file when that file is a module, but this file has no imports or exports. Consider adding an empty 'export {}' to make this file a module. | ||
awaitUsingDeclarationsInForAwaitOf.2.ts(4,32): error TS2448: Block-scoped variable 'of' used before its declaration. | ||
|
||
|
||
==== awaitUsingDeclarationsInForAwaitOf.2.ts (2 errors) ==== | ||
// https://github.com/microsoft/TypeScript/issues/55555 | ||
|
||
{ | ||
for await (await using of of of) {}; | ||
~~~~~ | ||
!!! error TS1431: 'for await' loops are only allowed at the top level of a file when that file is a module, but this file has no imports or exports. Consider adding an empty 'export {}' to make this file a module. | ||
~~ | ||
!!! error TS2448: Block-scoped variable 'of' used before its declaration. | ||
!!! related TS2728 awaitUsingDeclarationsInForAwaitOf.2.ts:4:26: 'of' is declared here. | ||
} |
15 changes: 15 additions & 0 deletions
15
tests/baselines/reference/awaitUsingDeclarationsInForAwaitOf.2.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
//// [tests/cases/conformance/statements/VariableStatements/usingDeclarations/awaitUsingDeclarationsInForAwaitOf.2.ts] //// | ||
|
||
//// [awaitUsingDeclarationsInForAwaitOf.2.ts] | ||
// https://github.com/microsoft/TypeScript/issues/55555 | ||
|
||
{ | ||
for await (await using of of of) {}; | ||
} | ||
|
||
//// [awaitUsingDeclarationsInForAwaitOf.2.js] | ||
// https://github.com/microsoft/TypeScript/issues/55555 | ||
{ | ||
for await (await using of of of) { } | ||
; | ||
} |
20 changes: 0 additions & 20 deletions
20
tests/baselines/reference/awaitUsingDeclarationsInForOf.2.errors.txt
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
tests/baselines/reference/awaitUsingDeclarationsInForOf.4.errors.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
awaitUsingDeclarationsInForOf.4.ts(4,8): error TS2853: 'await using' statements are only allowed at the top level of a file when that file is a module, but this file has no imports or exports. Consider adding an empty 'export {}' to make this file a module. | ||
awaitUsingDeclarationsInForOf.4.ts(4,26): error TS2448: Block-scoped variable 'of' used before its declaration. | ||
|
||
|
||
==== awaitUsingDeclarationsInForOf.4.ts (2 errors) ==== | ||
// https://github.com/microsoft/TypeScript/issues/55555 | ||
|
||
{ | ||
for (await using of of of) {}; | ||
~~~~~ | ||
!!! error TS2853: 'await using' statements are only allowed at the top level of a file when that file is a module, but this file has no imports or exports. Consider adding an empty 'export {}' to make this file a module. | ||
~~ | ||
!!! error TS2448: Block-scoped variable 'of' used before its declaration. | ||
!!! related TS2728 awaitUsingDeclarationsInForOf.4.ts:4:20: 'of' is declared here. | ||
} | ||
|
16 changes: 16 additions & 0 deletions
16
tests/baselines/reference/awaitUsingDeclarationsInForOf.4.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
//// [tests/cases/conformance/statements/VariableStatements/usingDeclarations/awaitUsingDeclarationsInForOf.4.ts] //// | ||
|
||
//// [awaitUsingDeclarationsInForOf.4.ts] | ||
// https://github.com/microsoft/TypeScript/issues/55555 | ||
|
||
{ | ||
for (await using of of of) {}; | ||
} | ||
|
||
|
||
//// [awaitUsingDeclarationsInForOf.4.js] | ||
// https://github.com/microsoft/TypeScript/issues/55555 | ||
{ | ||
for (await using of of of) { } | ||
; | ||
} |
10 changes: 10 additions & 0 deletions
10
...e/statements/VariableStatements/usingDeclarations/awaitUsingDeclarationsInForAwaitOf.2.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
// @target: esnext | ||
// @module: esnext | ||
// @lib: esnext | ||
// @noTypesAndSymbols: true | ||
|
||
// https://github.com/microsoft/TypeScript/issues/55555 | ||
|
||
{ | ||
for await (await using of of of) {}; | ||
} |
10 changes: 10 additions & 0 deletions
10
...rmance/statements/VariableStatements/usingDeclarations/awaitUsingDeclarationsInForOf.4.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
// @target: esnext | ||
// @module: esnext | ||
// @lib: esnext | ||
// @noTypesAndSymbols: true | ||
|
||
// https://github.com/microsoft/TypeScript/issues/55555 | ||
|
||
{ | ||
for (await using of of of) {}; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we put this in an async context, like an
async function
so that we don't have this spurious error inerrors.txt
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just pushed out the requested change. Could you take another look at this?