Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display write type for property accesses in write locations #54777

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Display write type for property accesses in write locations #54777

merged 1 commit into from
Aug 15, 2023

Conversation

Andarist
Copy link
Contributor

closes #53305

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jun 26, 2023
@jakebailey
Copy link
Member

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot run dt
@typescript-bot perf test this
@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 28, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the tarball bundle task on this PR at 7a755d2. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 28, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based top-repos suite (tsserver) on this PR at 7a755d2. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 28, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based user code test suite (tsserver) on this PR at 7a755d2. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 28, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 7a755d2. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 28, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 7a755d2. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 28, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the extended test suite on this PR at 7a755d2. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 28, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the perf test suite on this PR at 7a755d2. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 28, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 7a755d2. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 28, 2023 •
edited
Loading

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/155726/artifacts?artifactName=tgz&fileId=A69E37B9212D62DCD67B1D2B07773EE71184B62F0341BD915A86B2842E31D65B02&fileName=/typescript-5.2.0-insiders.20230628.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.2.0-pr-54777-9".;

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/54777/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/54777/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Unknown failure"
  • 1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

  • [NEW] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
    • /home/vsts/work/1/s/typescript-54777/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-54777/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-54777/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-54777/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-54777/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-54777/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-54777/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-54777/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-54777/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-54777/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-54777/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-54777/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-54777/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-54777/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-54777/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
  • [MISSING] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..54777
Metric main 54777 Delta Best Worst p-value
Angular - node (v18.10.0, x64)
Memory used 366,753k (± 0.01%) 366,716k (± 0.01%) ~ 366,691k 366,756k p=0.199 n=6
Parse Time 3.46s (± 0.60%) 3.41s (± 1.10%) ~ 3.37s 3.47s p=0.054 n=6
Bind Time 1.12s (± 0.67%) 1.12s (± 0.49%) ~ 1.11s 1.12s p=0.137 n=6
Check Time 8.88s (± 0.44%) 8.88s (± 0.51%) ~ 8.82s 8.93s p=0.809 n=6
Emit Time 7.54s (± 0.90%) 7.56s (± 0.79%) ~ 7.44s 7.60s p=0.936 n=6
Total Time 21.00s (± 0.52%) 20.96s (± 0.52%) ~ 20.79s 21.07s p=0.688 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used 193,823k (± 1.63%) 190,978k (± 0.01%) ~ 190,952k 191,020k p=0.575 n=6
Parse Time 1.50s (± 0.91%) 1.51s (± 0.70%) ~ 1.49s 1.52s p=1.000 n=6
Bind Time 0.77s (± 0.00%) 0.77s (± 1.28%) ~ 0.76s 0.78s p=0.652 n=6
Check Time 9.49s (± 0.82%) 9.43s (± 0.37%) ~ 9.39s 9.48s p=0.065 n=6
Emit Time 2.76s (± 0.68%) 2.76s (± 0.72%) ~ 2.72s 2.78s p=1.000 n=6
Total Time 14.52s (± 0.45%) 14.46s (± 0.32%) ~ 14.40s 14.54s p=0.108 n=6
Monaco - node (v18.10.0, x64)
Memory used 346,806k (± 0.01%) 346,810k (± 0.01%) ~ 346,776k 346,830k p=0.936 n=6
Parse Time 2.60s (± 0.97%) 2.60s (± 1.22%) ~ 2.55s 2.65s p=0.935 n=6
Bind Time 1.01s (± 1.25%) 1.01s (± 1.46%) ~ 0.99s 1.03s p=0.802 n=6
Check Time 7.22s (± 0.48%) 7.18s (± 0.53%) ~ 7.13s 7.23s p=0.064 n=6
Emit Time 4.26s (± 1.01%) 4.26s (± 0.41%) ~ 4.23s 4.27s p=0.685 n=6
Total Time 15.10s (± 0.64%) 15.04s (± 0.20%) ~ 15.00s 15.08s p=0.230 n=6
TFS - node (v18.10.0, x64)
Memory used 300,881k (± 0.01%) 300,861k (± 0.00%) ~ 300,840k 300,874k p=0.065 n=6
Parse Time 2.09s (± 1.16%) 2.06s (± 0.94%) ~ 2.03s 2.08s p=0.062 n=6
Bind Time 1.14s (± 0.73%) 1.14s (± 0.72%) ~ 1.13s 1.15s p=0.120 n=6
Check Time 6.68s (± 0.21%) 6.61s (± 0.46%) -0.07s (- 1.05%) 6.58s 6.65s p=0.005 n=6
Emit Time 3.86s (± 0.69%) 3.86s (± 1.00%) ~ 3.83s 3.93s p=0.625 n=6
Total Time 13.78s (± 0.20%) 13.67s (± 0.37%) -0.11s (- 0.82%) 13.59s 13.74s p=0.005 n=6
material-ui - node (v18.10.0, x64)
Memory used 482,455k (± 0.01%) 482,428k (± 0.01%) ~ 482,394k 482,499k p=0.173 n=6
Parse Time 3.13s (± 0.44%) 3.11s (± 0.56%) -0.03s (- 0.90%) 3.09s 3.14s p=0.034 n=6
Bind Time 0.92s (± 1.44%) 0.92s (± 1.31%) ~ 0.91s 0.94s p=0.931 n=6
Check Time 17.44s (± 0.43%) 17.26s (± 0.47%) -0.18s (- 1.03%) 17.17s 17.36s p=0.008 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 21.50s (± 0.38%) 21.29s (± 0.43%) -0.21s (- 0.95%) 21.20s 21.42s p=0.006 n=6
xstate - node (v18.10.0, x64)
Memory used 563,567k (± 0.02%) 563,504k (± 0.01%) ~ 563,448k 563,639k p=0.173 n=6
Parse Time 3.85s (± 0.75%) 3.85s (± 0.54%) ~ 3.82s 3.87s p=0.936 n=6
Bind Time 1.64s (± 0.50%) 1.64s (± 0.64%) ~ 1.63s 1.66s p=1.000 n=6
Check Time 2.80s (± 0.93%) 2.79s (± 0.74%) ~ 2.76s 2.81s p=0.935 n=6
Emit Time 0.08s (± 0.00%) 0.08s (± 0.00%) ~ 0.08s 0.08s p=1.000 n=6
Total Time 8.37s (± 0.42%) 8.37s (± 0.46%) ~ 8.32s 8.40s p=1.000 n=6
Angular - node (v16.17.1, x64)
Memory used 366,124k (± 0.01%) 366,124k (± 0.00%) ~ 366,109k 366,151k p=1.000 n=6
Parse Time 3.58s (± 0.23%) 3.59s (± 1.05%) ~ 3.55s 3.66s p=0.607 n=6
Bind Time 1.18s (± 0.44%) 1.18s (± 0.44%) ~ 1.17s 1.18s p=0.069 n=6
Check Time 9.65s (± 0.57%) 9.77s (± 2.09%) ~ 9.59s 10.16s p=0.293 n=6
Emit Time 8.01s (± 0.83%) 8.04s (± 0.68%) ~ 7.97s 8.11s p=0.295 n=6
Total Time 22.42s (± 0.55%) 22.57s (± 1.29%) ~ 22.29s 23.12s p=0.336 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 192,825k (± 0.02%) 192,771k (± 0.05%) ~ 192,655k 192,872k p=0.470 n=6
Parse Time 1.60s (± 1.07%) 1.59s (± 1.24%) ~ 1.58s 1.63s p=0.454 n=6
Bind Time 0.83s (± 0.62%) 0.82s (± 0.92%) ~ 0.81s 0.83s p=0.069 n=6
Check Time 10.17s (± 0.56%) 10.08s (± 0.57%) -0.09s (- 0.84%) 10.01s 10.18s p=0.044 n=6
Emit Time 3.04s (± 1.18%) 3.03s (± 1.10%) ~ 2.98s 3.08s p=0.333 n=6
Total Time 15.63s (± 0.54%) 15.52s (± 0.28%) -0.11s (- 0.72%) 15.47s 15.59s p=0.010 n=6
Monaco - node (v16.17.1, x64)
Memory used 346,064k (± 0.01%) 346,064k (± 0.00%) ~ 346,049k 346,085k p=0.574 n=6
Parse Time 2.74s (± 0.45%) 2.73s (± 0.73%) ~ 2.70s 2.75s p=0.157 n=6
Bind Time 1.09s (± 0.00%) 1.08s (± 0.50%) ~ 1.08s 1.09s p=0.071 n=6
Check Time 7.89s (± 0.38%) 7.88s (± 0.29%) ~ 7.85s 7.90s p=0.220 n=6
Emit Time 4.48s (± 0.61%) 4.48s (± 0.75%) ~ 4.45s 4.53s p=0.935 n=6
Total Time 16.21s (± 0.27%) 16.17s (± 0.32%) ~ 16.10s 16.25s p=0.335 n=6
TFS - node (v16.17.1, x64)
Memory used 300,215k (± 0.01%) 300,216k (± 0.01%) ~ 300,192k 300,234k p=0.936 n=6
Parse Time 2.19s (± 0.75%) 2.17s (± 0.68%) -0.03s (- 1.21%) 2.15s 2.19s p=0.028 n=6
Bind Time 1.24s (± 0.83%) 1.24s (± 0.88%) ~ 1.23s 1.25s p=0.676 n=6
Check Time 7.35s (± 0.61%) 7.34s (± 0.28%) ~ 7.30s 7.35s p=0.744 n=6
Emit Time 4.35s (± 0.51%) 4.35s (± 0.53%) ~ 4.32s 4.38s p=1.000 n=6
Total Time 15.14s (± 0.59%) 15.10s (± 0.28%) ~ 15.03s 15.15s p=0.521 n=6
material-ui - node (v16.17.1, x64)
Memory used 481,706k (± 0.01%) 481,710k (± 0.01%) ~ 481,663k 481,792k p=0.810 n=6
Parse Time 3.27s (± 0.27%) 3.26s (± 0.55%) ~ 3.24s 3.29s p=0.222 n=6
Bind Time 0.96s (± 0.54%) 0.95s (± 0.67%) ~ 0.94s 0.96s p=0.091 n=6
Check Time 18.34s (± 0.65%) 18.31s (± 0.61%) ~ 18.17s 18.51s p=0.873 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.56s (± 0.56%) 22.53s (± 0.49%) ~ 22.39s 22.72s p=0.748 n=6
xstate - node (v16.17.1, x64)
Memory used 561,181k (± 0.02%) 561,237k (± 0.04%) ~ 561,059k 561,540k p=0.748 n=6
Parse Time 4.03s (± 0.44%) 4.00s (± 0.31%) -0.03s (- 0.62%) 3.99s 4.02s p=0.035 n=6
Bind Time 1.75s (± 0.60%) 1.73s (± 0.57%) -0.02s (- 0.96%) 1.72s 1.74s p=0.032 n=6
Check Time 3.06s (± 0.48%) 3.06s (± 0.53%) ~ 3.03s 3.08s p=1.000 n=6
Emit Time 0.09s (± 4.45%) 0.09s (± 5.53%) ~ 0.09s 0.10s p=0.595 n=6
Total Time 8.93s (± 0.15%) 8.88s (± 0.29%) -0.05s (- 0.52%) 8.84s 8.92s p=0.012 n=6
Angular - node (v14.21.3, x64)
Memory used 360,100k (± 0.01%) 360,114k (± 0.01%) ~ 360,066k 360,174k p=0.689 n=6
Parse Time 3.68s (± 0.53%) 3.66s (± 0.56%) ~ 3.64s 3.70s p=0.104 n=6
Bind Time 1.23s (± 0.98%) 1.21s (± 0.43%) -0.02s (- 1.62%) 1.21s 1.22s p=0.010 n=6
Check Time 10.11s (± 0.38%) 10.08s (± 0.60%) ~ 10.01s 10.17s p=0.466 n=6
Emit Time 8.42s (± 0.68%) 8.40s (± 0.88%) ~ 8.33s 8.54s p=0.374 n=6
Total Time 23.43s (± 0.33%) 23.36s (± 0.42%) ~ 23.27s 23.50s p=0.127 n=6
Compiler-Unions - node (v14.21.3, x64)
Memory used 188,155k (± 0.01%) 188,145k (± 0.01%) ~ 188,128k 188,166k p=0.336 n=6
Parse Time 1.63s (± 0.50%) 1.63s (± 0.75%) ~ 1.61s 1.64s p=0.730 n=6
Bind Time 0.85s (± 0.00%) 0.85s (± 0.96%) ~ 0.84s 0.86s p=0.290 n=6
Check Time 10.34s (± 0.45%) 10.25s (± 0.69%) ~ 10.17s 10.36s p=0.066 n=6
Emit Time 3.14s (± 0.81%) 3.14s (± 0.55%) ~ 3.11s 3.16s p=0.806 n=6
Total Time 15.95s (± 0.33%) 15.87s (± 0.51%) ~ 15.77s 15.97s p=0.076 n=6
Monaco - node (v14.21.3, x64)
Memory used 341,191k (± 0.01%) 341,201k (± 0.01%) ~ 341,173k 341,238k p=0.471 n=6
Parse Time 2.83s (± 0.55%) 2.81s (± 0.69%) ~ 2.79s 2.84s p=0.085 n=6
Bind Time 1.11s (± 0.73%) 1.11s (± 0.68%) ~ 1.10s 1.12s p=1.000 n=6
Check Time 8.25s (± 0.37%) 8.21s (± 0.37%) ~ 8.16s 8.25s p=0.053 n=6
Emit Time 4.71s (± 0.78%) 4.66s (± 0.36%) -0.05s (- 1.03%) 4.63s 4.67s p=0.034 n=6
Total Time 16.90s (± 0.34%) 16.79s (± 0.27%) -0.11s (- 0.68%) 16.73s 16.84s p=0.010 n=6
TFS - node (v14.21.3, x64)
Memory used 295,306k (± 0.00%) 295,303k (± 0.00%) ~ 295,290k 295,314k p=0.419 n=6
Parse Time 2.41s (± 0.93%) 2.40s (± 0.90%) ~ 2.38s 2.44s p=0.870 n=6
Bind Time 1.07s (± 0.48%) 1.06s (± 0.77%) ~ 1.06s 1.08s p=0.235 n=6
Check Time 7.65s (± 0.36%) 7.65s (± 0.32%) ~ 7.62s 7.68s p=0.936 n=6
Emit Time 4.31s (± 0.78%) 4.29s (± 0.63%) ~ 4.25s 4.33s p=0.373 n=6
Total Time 15.43s (± 0.46%) 15.41s (± 0.30%) ~ 15.35s 15.48s p=0.422 n=6
material-ui - node (v14.21.3, x64)
Memory used 477,166k (± 0.00%) 477,170k (± 0.00%) ~ 477,145k 477,197k p=0.810 n=6
Parse Time 3.36s (± 0.42%) 3.34s (± 0.42%) ~ 3.32s 3.36s p=0.051 n=6
Bind Time 1.01s (± 0.00%) 1.00s (± 0.41%) -0.01s (- 0.83%) 1.00s 1.01s p=0.007 n=6
Check Time 19.40s (± 0.72%) 19.20s (± 0.27%) -0.20s (- 1.03%) 19.15s 19.30s p=0.013 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 23.77s (± 0.60%) 23.54s (± 0.22%) -0.23s (- 0.97%) 23.50s 23.64s p=0.013 n=6
xstate - node (v14.21.3, x64)
Memory used 550,174k (± 0.01%) 550,177k (± 0.00%) ~ 550,147k 550,193k p=0.423 n=6
Parse Time 4.25s (± 0.18%) 4.24s (± 0.21%) ~ 4.23s 4.25s p=0.149 n=6
Bind Time 1.68s (± 1.15%) 1.66s (± 0.93%) ~ 1.64s 1.68s p=0.073 n=6
Check Time 3.14s (± 0.66%) 3.13s (± 0.75%) ~ 3.10s 3.16s p=0.936 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=1.000 n=6
Total Time 9.15s (± 0.32%) 9.13s (± 0.26%) ~ 9.09s 9.15s p=0.332 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-148-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.21.3, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.21.3, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.21.3, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.21.3, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.21.3, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.21.3, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.21.3, x64)
Benchmark Name Iterations
Current 54777 6
Baseline main 6

TSServer

Comparison Report - main..54777
Metric main 54777 Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,575ms (± 0.93%) 2,562ms (± 0.83%) ~ 2,540ms 2,595ms p=0.298 n=6
Req 2 - geterr 5,373ms (± 0.79%) 5,344ms (± 0.61%) ~ 5,301ms 5,400ms p=0.230 n=6
Req 3 - references 342ms (± 1.15%) 340ms (± 0.47%) ~ 339ms 343ms p=0.744 n=6
Req 4 - navto 288ms (± 0.42%) 287ms (± 0.36%) ~ 286ms 289ms p=0.675 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 82ms (± 3.73%) 83ms (± 2.70%) ~ 79ms 85ms p=0.680 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,655ms (± 1.15%) 2,651ms (± 0.96%) ~ 2,611ms 2,685ms p=1.000 n=6
Req 2 - geterr 4,136ms (± 1.98%) 4,091ms (± 0.28%) ~ 4,078ms 4,105ms p=0.199 n=6
Req 3 - references 349ms (± 0.97%) 346ms (± 0.57%) ~ 344ms 349ms p=0.222 n=6
Req 4 - navto 287ms (± 0.41%) 288ms (± 0.66%) ~ 286ms 290ms p=0.314 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 71ms (± 1.26%) 76ms (± 9.08%) ~ 71ms 89ms p=0.084 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,112ms (± 0.40%) 3,096ms (± 0.42%) ~ 3,082ms 3,117ms p=0.092 n=6
Req 2 - geterr 1,604ms (± 0.64%) 1,587ms (± 0.56%) -17ms (- 1.03%) 1,573ms 1,599ms p=0.020 n=6
Req 3 - references 112ms (± 0.92%) 113ms (± 1.09%) ~ 111ms 114ms p=0.804 n=6
Req 4 - navto 370ms (± 0.44%) 370ms (± 1.34%) ~ 366ms 379ms p=0.332 n=6
Req 5 - completionInfo count 2,872 (± 0.00%) 2,872 (± 0.00%) ~ 2,872 2,872 p=1.000 n=6
Req 5 - completionInfo 378ms (± 1.50%) 375ms (± 1.44%) ~ 368ms 383ms p=0.419 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,669ms (± 1.42%) 2,639ms (± 0.77%) ~ 2,616ms 2,667ms p=0.199 n=6
Req 2 - geterr 5,988ms (± 1.75%) 6,000ms (± 0.35%) ~ 5,964ms 6,023ms p=0.296 n=6
Req 3 - references 354ms (± 0.43%) 353ms (± 0.69%) ~ 349ms 356ms p=0.413 n=6
Req 4 - navto 285ms (± 0.69%) 285ms (± 0.31%) ~ 284ms 286ms p=0.934 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 89ms (± 8.89%) 89ms (± 8.92%) ~ 73ms 94ms p=1.000 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,853ms (± 0.69%) 2,835ms (± 0.67%) ~ 2,819ms 2,861ms p=0.297 n=6
Req 2 - geterr 4,680ms (± 0.37%) 4,675ms (± 0.41%) ~ 4,648ms 4,697ms p=0.872 n=6
Req 3 - references 365ms (± 0.48%) 364ms (± 0.80%) ~ 359ms 367ms p=0.466 n=6
Req 4 - navto 285ms (± 0.52%) 283ms (± 0.91%) ~ 279ms 286ms p=0.184 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 75ms (± 1.19%) 75ms (± 0.54%) ~ 75ms 76ms p=0.787 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,266ms (± 0.73%) 3,235ms (± 0.50%) ~ 3,221ms 3,265ms p=0.054 n=6
Req 2 - geterr 1,751ms (± 1.13%) 1,755ms (± 0.92%) ~ 1,734ms 1,777ms p=0.471 n=6
Req 3 - references 127ms (± 6.77%) 122ms (± 1.70%) ~ 119ms 124ms p=0.180 n=6
Req 4 - navto 357ms (± 0.72%) 352ms (± 0.82%) -5ms (- 1.49%) 348ms 355ms p=0.019 n=6
Req 5 - completionInfo count 2,872 (± 0.00%) 2,872 (± 0.00%) ~ 2,872 2,872 p=1.000 n=6
Req 5 - completionInfo 410ms (± 1.80%) 416ms (± 2.05%) ~ 404ms 425ms p=0.336 n=6
Compiler-UnionsTSServer - node (v14.21.3, x64)
Req 1 - updateOpen 2,822ms (± 0.59%) 2,788ms (± 0.55%) -34ms (- 1.20%) 2,773ms 2,816ms p=0.013 n=6
Req 2 - geterr 6,211ms (± 0.45%) 6,189ms (± 0.67%) ~ 6,139ms 6,234ms p=0.521 n=6
Req 3 - references 361ms (± 0.67%) 362ms (± 0.42%) ~ 360ms 364ms p=0.622 n=6
Req 4 - navto 292ms (± 0.40%) 292ms (± 0.45%) ~ 290ms 293ms p=1.000 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 102ms (± 6.17%) 104ms (± 1.12%) ~ 102ms 105ms p=0.452 n=6
CompilerTSServer - node (v14.21.3, x64)
Req 1 - updateOpen 2,990ms (± 0.45%) 2,975ms (± 0.29%) ~ 2,964ms 2,989ms p=0.066 n=6
Req 2 - geterr 4,556ms (± 0.61%) 4,549ms (± 0.68%) ~ 4,512ms 4,577ms p=1.000 n=6
Req 3 - references 377ms (± 0.52%) 377ms (± 0.60%) ~ 373ms 379ms p=1.000 n=6
Req 4 - navto 300ms (± 0.49%) 299ms (± 0.47%) ~ 297ms 301ms p=0.222 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 77ms (± 0.53%) 76ms (± 1.53%) ~ 75ms 78ms p=0.227 n=6
xstateTSServer - node (v14.21.3, x64)
Req 1 - updateOpen 3,491ms (± 0.72%) 3,477ms (± 0.43%) ~ 3,455ms 3,493ms p=0.378 n=6
Req 2 - geterr 1,856ms (± 1.09%) 1,858ms (± 0.41%) ~ 1,848ms 1,869ms p=0.810 n=6
Req 3 - references 152ms (± 6.75%) 151ms (± 7.75%) ~ 135ms 161ms p=0.872 n=6
Req 4 - navto 397ms (± 0.37%) 397ms (± 0.34%) ~ 395ms 399ms p=0.934 n=6
Req 5 - completionInfo count 2,872 (± 0.00%) 2,872 (± 0.00%) ~ 2,872 2,872 p=1.000 n=6
Req 5 - completionInfo 432ms (± 2.81%) 435ms (± 1.42%) ~ 427ms 442ms p=0.573 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-148-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.21.3, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.21.3, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.21.3, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.21.3, x64)
Benchmark Name Iterations
Current 54777 6
Baseline main 6

Startup

Comparison Report - main..54777
Metric main 54777 Delta Best Worst p-value
tsc-startup - node (v16.17.1, x64)
Execution time 143.72ms (± 0.39%) 142.83ms (± 0.22%) -0.89ms (- 0.62%) 141.94ms 146.22ms p=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time 225.73ms (± 0.51%) 222.83ms (± 0.21%) -2.90ms (- 1.28%) 221.45ms 227.75ms p=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 226.13ms (± 0.40%) 225.91ms (± 0.38%) -0.21ms (- 0.09%) 223.08ms 231.09ms p=0.043 n=600
typescript-startup - node (v16.17.1, x64)
Execution time 207.95ms (± 0.41%) 207.98ms (± 0.39%) ~ 204.95ms 215.84ms p=0.623 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-148-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 54777 6
Baseline main 6

Developer Information:

Download Benchmark

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/54777/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/54777/merge:

Everything looks good!

@jakebailey
Copy link
Member

Generally speaking I think I probably need to have @RyanCavanaugh / @DanielRosenwasser give the resulting setup a once over to make sure it lines up with their mental models; I think it matches Ryan's comment in the linked issue, but I'm also a little unsure that I like the end result either.

@jakebailey
Copy link
Member

Just going to do a quick close/open since this is 151 commits behind main.

@jakebailey jakebailey closed this Aug 15, 2023
@jakebailey jakebailey reopened this Aug 15, 2023
@jakebailey jakebailey merged commit b8b0d26 into microsoft:main Aug 15, 2023
16 checks passed
This was referenced Aug 16, 2023
Closed
Open
Closed
@karlhorky
Copy link
Contributor

Thanks for the PR, review and merge @Andarist @DanielRosenwasser @jakebailey 🙌

@jakebailey jakebailey mentioned this pull request Aug 28, 2023
Closed
This was referenced Aug 29, 2023
Closed
Merged
@Andarist Andarist deleted the use-write-type-in-write-locations branch August 30, 2023 17:49
@Andarist Andarist mentioned this pull request Aug 31, 2023
Merged
snovader pushed a commit to mestro-se/TypeScript that referenced this pull request Sep 23, 2023
@Andarist @snovader
Display write type for property accesses in write locations (microsof…
78a1235 
…t#54777)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

@jakebailey jakebailey Awaiting requested review from jakebailey

@navya9singh navya9singh Awaiting requested review from navya9singh

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

@gabritto gabritto Awaiting requested review from gabritto

Assignees

@jakebailey jakebailey

Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

exactOptionalPropertyTypes does not include undefined in the type for assignment operators like ??=
5 participants
@Andarist @jakebailey @typescript-bot @karlhorky @DanielRosenwasser