Avoid calculating union in spread if property types are identical #53413

jakebailey · 2023-03-21T17:25:19Z

When spreading, we remove undefined from the right type and union it with the left. If the two types are huge but overlap, we'll add all of the union's members together into one big list, then run subtype reduction over it, which for this test takes a long time. But, we can skip that work if we can recognize that left/right are the same. With #53406, this eliminates all of the bottlenecks in #52345.

Since this spread stuff is tricky, I generated a test which tests all combos of spreading + optional + missing to verify that I don't screw it up.

Likely, there's something more general that could be done to getUnionType here; it always recurses into every union and then does subtype reduction. I wonder if we can deduplicate the list first (ignoring undefined-ness), and trivially bail out early where possible, but that seemed a little tricky.

jakebailey · 2023-03-21T17:34:53Z

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this faster

typescript-bot · 2023-03-21T17:34:56Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 958017d. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-21T17:34:56Z

Heya @jakebailey, I've started to run the abridged perf test suite on this PR at 958017d. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-21T17:34:56Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 958017d. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-21T17:34:56Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 958017d. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-21T17:34:56Z

Heya @jakebailey, I've started to run the extended test suite on this PR at 958017d. You can monitor the build here.

typescript-bot · 2023-03-21T17:48:19Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/53413/merge:

Everything looks good!

typescript-bot · 2023-03-21T18:02:38Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53413

_Metric	_main	₅₃₄₁₃	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{361,392k (± 0.01%)}	_{361,422k (± 0.01%)}	_~	_361,362k	_361,465k	_{p=0.199 n=6}
_{Parse Time}	_{3.54s (± 0.60%)}	_{3.52s (± 0.91%)}	_~	_3.49s	_3.56s	_{p=0.466 n=6}
_{Bind Time}	_{1.18s (± 0.71%)}	_{1.18s (± 0.46%)}	_~	_1.18s	_1.19s	_{p=0.855 n=6}
_{Check Time}	_{9.49s (± 0.44%)}	_{9.54s (± 0.37%)}	_~	_9.50s	_9.60s	_{p=0.064 n=6}
_{Emit Time}	_{7.92s (± 0.37%)}	_{7.97s (± 0.71%)}	_~	_7.92s	_8.07s	_{p=0.063 n=6}
_{Total Time}	_{22.13s (± 0.22%)}	_{22.22s (± 0.30%)}	_{+0.10s (+ 0.44%)}	_22.13s	_22.33s	_{p=0.024 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,532k (± 0.03%)}	_{192,515k (± 0.02%)}	_~	_192,463k	_192,582k	_{p=0.873 n=6}
_{Parse Time}	_{1.60s (± 0.85%)}	_{1.59s (± 1.08%)}	_~	_1.56s	_1.61s	_{p=0.317 n=6}
_{Bind Time}	_{0.83s (± 0.62%)}	_{0.82s (± 0.00%)}	_{-0.01s (- 0.81%)}	_0.82s	_0.82s	_{p=0.025 n=6}
_{Check Time}	_{10.18s (± 0.45%)}	_{10.11s (± 0.67%)}	_{-0.07s (- 0.72%)}	_10.06s	_10.24s	_{p=0.043 n=6}
_{Emit Time}	_{2.99s (± 1.21%)}	_{3.00s (± 1.02%)}	_~	_2.96s	_3.04s	_{p=0.809 n=6}
_{Total Time}	_{15.60s (± 0.30%)}	_{15.52s (± 0.64%)}	_~	_15.43s	_15.69s	_{p=0.126 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,562k (± 0.01%)}	_{345,556k (± 0.01%)}	_~	_345,538k	_345,582k	_{p=0.378 n=6}
_{Parse Time}	_{2.73s (± 0.50%)}	_{2.73s (± 0.51%)}	_~	_2.71s	_2.74s	_{p=0.935 n=6}
_{Bind Time}	_{1.09s (± 0.47%)}	_{1.09s (± 0.47%)}	_~	_1.08s	_1.09s	_{p=1.000 n=6}
_{Check Time}	_{7.76s (± 0.52%)}	_{7.75s (± 0.57%)}	_~	_7.68s	_7.81s	_{p=0.808 n=6}
_{Emit Time}	_{4.48s (± 0.58%)}	_{4.46s (± 1.05%)}	_~	_4.43s	_4.55s	_{p=0.290 n=6}
_{Total Time}	_{16.06s (± 0.35%)}	_{16.02s (± 0.52%)}	_~	_15.93s	_16.16s	_{p=0.377 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,778k (± 0.01%)}	_{299,816k (± 0.01%)}	_~	_299,754k	_299,863k	_{p=0.173 n=6}
_{Parse Time}	_{2.17s (± 0.86%)}	_{2.16s (± 0.48%)}	_~	_2.14s	_2.17s	_{p=0.102 n=6}
_{Bind Time}	_{1.23s (± 1.03%)}	_{1.24s (± 1.14%)}	_~	_1.22s	_1.26s	_{p=0.249 n=6}
_{Check Time}	_{7.20s (± 0.39%)}	_{7.17s (± 0.44%)}	_~	_7.12s	_7.20s	_{p=0.107 n=6}
_{Emit Time}	_{4.34s (± 0.50%)}	_{4.33s (± 0.60%)}	_~	_4.30s	_4.37s	_{p=0.331 n=6}
_{Total Time}	_{14.93s (± 0.32%)}	_{14.89s (± 0.28%)}	_~	_14.84s	_14.96s	_{p=0.173 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{476,489k (± 0.02%)}	_{476,371k (± 0.00%)}	_{-118k (- 0.02%)}	_476,351k	_476,391k	_{p=0.013 n=6}
_{Parse Time}	_{3.22s (± 1.21%)}	_{3.22s (± 0.32%)}	_~	_3.20s	_3.23s	_{p=0.366 n=6}
_{Bind Time}	_{0.98s (± 3.78%)}	_{0.95s (± 0.57%)}	_{-0.03s (- 2.72%)}	_0.95s	_0.96s	_{p=0.038 n=6}
_{Check Time}	_{18.00s (± 1.06%)}	_{17.93s (± 0.40%)}	_~	_17.84s	_18.03s	_{p=0.688 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.20s (± 1.03%)}	_{22.10s (± 0.31%)}	_~	_22.02s	_22.18s	_{p=0.689 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{550,558k (± 0.01%)}	_{550,529k (± 0.01%)}	_~	_550,489k	_550,600k	_{p=0.471 n=6}
_{Parse Time}	_{3.95s (± 0.34%)}	_{3.95s (± 0.23%)}	_~	_3.94s	_3.96s	_{p=0.681 n=6}
_{Bind Time}	_{1.79s (± 0.47%)}	_{1.79s (± 0.58%)}	_~	_1.78s	_1.81s	_{p=1.000 n=6}
_{Check Time}	_{2.99s (± 0.47%)}	_{2.99s (± 0.91%)}	_~	_2.96s	_3.02s	_{p=0.513 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.83s (± 0.34%)}	_{8.83s (± 0.37%)}	_~	_8.79s	_8.87s	_{p=0.747 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₄₁₃	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

weswigham

We could probably build a similar check into getUnionType directly, but the undefined handling (as done here) does make it a bit tricker.

typescript-bot · 2023-03-21T19:19:26Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/53413/merge:

Everything looks good!

typescript-bot · 2023-03-21T19:28:44Z

Hey @jakebailey, it looks like the DT test run failed. Please check the log for more details.
You can check the log here.

jakebailey · 2023-03-21T19:35:36Z

@typescript-bot run dt but this time don't fail please

typescript-bot · 2023-03-21T19:35:39Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 958017d. You can monitor the build here.

Update: The results are in!

jakebailey · 2023-03-21T20:20:51Z

@typescript-bot pack this

typescript-bot · 2023-03-21T20:20:53Z

Heya @jakebailey, I've started to run the tarball bundle task on this PR at 958017d. You can monitor the build here.

typescript-bot · 2023-03-21T20:23:12Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/150524/artifacts?artifactName=tgz&fileId=500A00E3BCD5C97B02ABAC8526FB418BC7F239F8EF69AF70BD2D56952FEE16B702&fileName=/typescript-5.1.0-insiders.20230321.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.1.0-pr-53413-14".;

typescript-bot · 2023-03-21T21:38:47Z

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

jakebailey added 2 commits March 21, 2023 10:01

Add test for all combos of spreads

640743f

Avoid calculating union in spread if types are identical

958017d

typescript-bot assigned jakebailey Mar 21, 2023

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Mar 21, 2023

jakebailey changed the title ~~Avoid calculating union in spread if types are identical~~ Avoid calculating union in spread if property types are identical Mar 21, 2023

jakebailey requested a review from weswigham March 21, 2023 18:18

weswigham approved these changes Mar 21, 2023

View reviewed changes

jakebailey mentioned this pull request Mar 21, 2023

Ignore template literal types which contain intersections in removeStringLiteralsMatchedByTemplateLiterals #53406

Closed

typescript-bot added For Uncommitted Bug PR for untriaged, rejected, closed or missing bug and removed For Milestone Bug PRs that fix a bug with a specific milestone labels Mar 21, 2023

epmatsw mentioned this pull request Mar 21, 2023

Performance regression from #48044 #52345

Closed

jakebailey merged commit 01de788 into microsoft:main Mar 21, 2023

jakebailey deleted the fix-52345-4 branch March 21, 2023 21:44

This was referenced Mar 4, 2024

Spurious [?] circularity error in getter with spread #48178

Closed

Add a test case related to spreading objects #57642

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid calculating union in spread if property types are identical #53413

Avoid calculating union in spread if property types are identical #53413

jakebailey commented Mar 21, 2023 •

edited

Loading

jakebailey commented Mar 21, 2023

typescript-bot commented Mar 21, 2023 •

edited

Loading

typescript-bot commented Mar 21, 2023 •

edited

Loading

typescript-bot commented Mar 21, 2023 •

edited

Loading

typescript-bot commented Mar 21, 2023 •

edited

Loading

typescript-bot commented Mar 21, 2023 •

edited

Loading

typescript-bot commented Mar 21, 2023

typescript-bot commented Mar 21, 2023

weswigham left a comment •

edited

Loading

typescript-bot commented Mar 21, 2023

typescript-bot commented Mar 21, 2023

jakebailey commented Mar 21, 2023

typescript-bot commented Mar 21, 2023 •

edited

Loading

jakebailey commented Mar 21, 2023

typescript-bot commented Mar 21, 2023 •

edited

Loading

typescript-bot commented Mar 21, 2023 •

edited

Loading

typescript-bot commented Mar 21, 2023

Avoid calculating union in spread if property types are identical #53413

Avoid calculating union in spread if property types are identical #53413

Conversation

jakebailey commented Mar 21, 2023 • edited Loading

jakebailey commented Mar 21, 2023

typescript-bot commented Mar 21, 2023 • edited Loading

typescript-bot commented Mar 21, 2023 • edited Loading

typescript-bot commented Mar 21, 2023 • edited Loading

typescript-bot commented Mar 21, 2023 • edited Loading

typescript-bot commented Mar 21, 2023 • edited Loading

typescript-bot commented Mar 21, 2023

typescript-bot commented Mar 21, 2023

weswigham left a comment • edited Loading

Choose a reason for hiding this comment

typescript-bot commented Mar 21, 2023

typescript-bot commented Mar 21, 2023

jakebailey commented Mar 21, 2023

typescript-bot commented Mar 21, 2023 • edited Loading

jakebailey commented Mar 21, 2023

typescript-bot commented Mar 21, 2023 • edited Loading

typescript-bot commented Mar 21, 2023 • edited Loading

typescript-bot commented Mar 21, 2023

jakebailey commented Mar 21, 2023 •

edited

Loading

typescript-bot commented Mar 21, 2023 •

edited

Loading

typescript-bot commented Mar 21, 2023 •

edited

Loading

typescript-bot commented Mar 21, 2023 •

edited

Loading

typescript-bot commented Mar 21, 2023 •

edited

Loading

typescript-bot commented Mar 21, 2023 •

edited

Loading

weswigham left a comment •

edited

Loading

typescript-bot commented Mar 21, 2023 •

edited

Loading

typescript-bot commented Mar 21, 2023 •

edited

Loading

typescript-bot commented Mar 21, 2023 •

edited

Loading