Fix(29118): tsconfig.extends as array #50403

navya9singh · 2022-08-22T16:11:55Z

sheetalkamat

All these you can either add assert that type is not "listOrElement"
https://github.com/microsoft/TypeScript/blob/main/src/compiler/builder.ts#L997
https://github.com/microsoft/TypeScript/blob/main/src/compiler/commandLineParser.ts#L2491
https://github.com/microsoft/TypeScript/blob/main/src/compiler/commandLineParser.ts#L2664
https://github.com/microsoft/TypeScript/blob/main/src/executeCommandLine/executeCommandLine.ts#L166
https://github.com/microsoft/TypeScript/blob/main/src/executeCommandLine/executeCommandLine.ts#L282
https://github.com/microsoft/TypeScript/blob/main/src/services/getEditsForFileRename.ts#L76

src/compiler/commandLineParser.ts

src/executeCommandLine/executeCommandLine.ts

src/testRunner/unittests/config/configurationExtension.ts

src/testRunner/unittests/config/showConfig.ts

src/testRunner/unittests/tsbuildWatch/programUpdates.ts

sheetalkamat

I will look into other comments later

src/testRunner/unittests/tsbuildWatch/programUpdates.ts

src/executeCommandLine/executeCommandLine.ts

src/compiler/commandLineParser.ts

RyanCavanaugh · 2022-08-24T22:18:34Z

src/executeCommandLine/executeCommandLine.ts

@@ -300,6 +300,14 @@ namespace ts {
                        // TODO: check infinite loop
                        possibleValues = getPossibleValues(option.element);
                        break;
+                    case "listOrElement":
+                        if (option.element.type === "string"){


Suggested change

if (option.element.type === "string"){

if (option.element.type === "string") {

RyanCavanaugh · 2022-08-24T22:19:15Z

src/compiler/commandLineParser.ts

+                            options[opt.name] = validateJsonOptionValue(opt, args[i] || "", errors);
+                            i++;
+                        }
+                        else{


Suggested change

else{

else {

RyanCavanaugh · 2022-08-24T22:19:31Z

src/compiler/commandLineParser.ts

@@ -2986,34 +3029,52 @@ namespace ts {
        if (ownConfig.extendedConfigPath) {
            // copy the resolution stack so it is never reused between branches in potential diamond-problem scenarios.
            resolutionStack = resolutionStack.concat([resolvedPath]);
-            const extendedConfig = getExtendedConfig(sourceFile, ownConfig.extendedConfigPath, host, resolutionStack, errors, extendedConfigCache);
+            const result: ExtendsResult = { options:{} };
+            if(isString(ownConfig.extendedConfigPath)){


Spaces throughout

RyanCavanaugh · 2022-08-29T19:23:32Z

src/compiler/commandLineParser.ts

-                                i++;
-                            }
-                        }
+                        Debug.fail();


Suggested change

Debug.fail();

Debug.fail("listOrElement not supported here");

src/compiler/commandLineParser.ts

src/executeCommandLine/executeCommandLine.ts

src/compiler/commandLineParser.ts

src/testRunner/unittests/tsbuildWatch/programUpdates.ts

src/compiler/commandLineParser.ts

src/testRunner/unittests/tsbuildWatch/programUpdates.ts

src/compiler/commandLineParser.ts

sheetalkamat · 2022-11-16T21:01:58Z

src/compiler/commandLineParser.ts

@@ -2513,6 +2529,7 @@ function serializeOptionBaseObject(
            const value = options[name] as CompilerOptionsValue;
            const optionDefinition = optionsNameMap.get(name.toLowerCase());
            if (optionDefinition) {
+                    Debug.assert(optionDefinition.type !== "listOrElement");


Please fix formatting for some of the changes that has been indented by one extra tab

src/testRunner/unittests/tsbuildWatch/programUpdates.ts

andrewbranch · 2022-12-06T21:24:14Z

Example:

// @Filename: /tsconfig1.json
{
  "compilerOptions": {
    "strictNullChecks": true
  }
}

// @Filename: /tsconfig2.json
{
  "compilerOptions": {
    "noImplicitAny": true
  }
}

// @Filename: /tsconfig.json
{
  "extends": ["./tsconfig1.json", "./tsconfig2.json"]
  "files": ["./index.ts"]
}

// @Filename: /index.ts
function f(x) {} // noImplicitAny error
let y: string;
y.toLowerCase(); // strictNullChecks error

sheetalkamat · 2022-12-06T21:29:34Z

@andrewbranch the compiler tests are hard to add with tsconfig. https://github.com/microsoft/TypeScript/pull/50403/files#diff-0556827a3985d4ffd3ed2e51ac63c9d86ba98ab41dca5c7711fb2750188cbe8a shows the test case where multiple tsconfigs are working together ? https://github.com/microsoft/TypeScript/pull/50403/files#diff-97bc6a439e0f02498deab0f7c919e4e7a2f06c6b4832fd2fc7b042f56b141ff9R111 baseline.

While said that we could add test in non watch mode as well.

andrewbranch · 2022-12-06T21:35:58Z

I saw that baseline, but I couldn’t find any indication in the baseline that the options in the extended configs were relevant. I was looking for a strictNullChecks or noImplicitAny error but didn’t see any. Maybe I missed it in the noise.

There are plenty of compiler tests with tsconfig files, but I don’t know if there are subtle gotchas with them.

sheetalkamat · 2022-12-06T22:05:44Z

@navya9singh you probably want to add test like https://github.com/microsoft/TypeScript/blob/main/src/testRunner/unittests/tsc/forceConsistentCasingInFileNames.ts with the contents of test files as shown by @andrewbranch for better clarity

DanielRosenwasser · 2022-12-07T19:59:09Z

@typescript-bot pack this

typescript-bot · 2022-12-07T19:59:12Z

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at bb0ae2f. You can monitor the build here.

typescript-bot · 2022-12-07T20:01:30Z

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/139933/artifacts?artifactName=tgz&fileId=43D4A075BE928283C15303888F67D4786C1B8B67071DA37D39B422AFBEEC049702&fileName=/typescript-5.0.0-insiders.20221207.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.0.0-pr-50403-6".;

andrewbranch · 2022-12-12T23:22:47Z

It looks like some changes landed in main that require you to update something in your unit tests. I’m guessing it’s #51798. You’ll want to manually merge main into this branch and then take a look at those test files that no longer build, using Sheetal’s PR as a reference for how to update them.

andrewbranch

Once the build is green, looks good to merge.

andrewbranch · 2022-12-13T19:15:13Z

orta · 2022-12-14T08:37:40Z

Very cool

bradley-marker-ck · 2023-03-31T19:14:45Z

Just a heads up if you're sharing a tsconfig from a package. It seems typescript@4.9.5 was not restricted by the exports from the package.json file. It is now with @typescript@5.0.3.

The tsconfig.json file not found error was the last error when running tsc.

In my case, it was also causing eslint (with @typescript-eslint/parser) to fail with out of memory errors. Since we run eslint before tsc, it was a few tries before I decided to skip eslint and run tsc and was able to find the problem.

tsconfig.extends as array

3b6917c

typescript-bot assigned navya9singh Aug 22, 2022

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Aug 22, 2022

navya9singh requested review from sheetalkamat, andrewbranch and RyanCavanaugh August 22, 2022 16:12

Updated baselines

a50904e

sheetalkamat requested changes Aug 22, 2022

View reviewed changes

Changes for pr

1717b53

sheetalkamat requested changes Aug 24, 2022

View reviewed changes

src/compiler/commandLineParser.ts Outdated Show resolved Hide resolved

src/compiler/commandLineParser.ts Outdated Show resolved Hide resolved

RyanCavanaugh reviewed Aug 24, 2022

View reviewed changes

Changes for pr comments

77f9b50

RyanCavanaugh reviewed Aug 29, 2022

View reviewed changes

sheetalkamat requested changes Sep 1, 2022

View reviewed changes

bluwy mentioned this pull request Sep 19, 2022

extending a tsconfig in .svelte-kit/tsconfig.json sveltejs/kit#6868

Closed

dominikg mentioned this pull request Sep 19, 2022

reminder: implement extends array resolve if it lands dominikg/tsconfck#67

Closed

This was referenced Oct 27, 2022

Design Meeting Notes, 10/26/2022 #51323

Closed

TypeScript 5.0 Iteration Plan #51362

Closed

azu mentioned this pull request Nov 2, 2022

2022-11-02のJS: Node.js 18.12.0 LTS、Babel 7.20.0、TypeScript 4.9 RC jser/jser.github.io#1016

Merged

Merged main, changes for pr, added test case

5ba95f7

sheetalkamat requested changes Nov 16, 2022

View reviewed changes

navya9singh added 3 commits November 28, 2022 10:50

Fixed formatting and edited a test

f85c772

Merge branch 'main' into fix(29118)

6558e04

Resolved errors after a merge conflict

de79220

Added compiler test

ef8bd6e

andrewbranch approved these changes Dec 12, 2022

View reviewed changes

navya9singh added 3 commits December 12, 2022 16:22

Merge branch 'main' into fix(29118)

3a3cdf7

Resolving programUpdate errors

e0d9de8

Fixing commandLineParser error

7d6bdb6

navya9singh merged commit 7267fca into main Dec 13, 2022

navya9singh deleted the fix(29118) branch December 13, 2022 19:16

aleksei-berezkin mentioned this pull request Dec 28, 2022

Multiple inheritance in tsconfig.json SchemaStore/schemastore#2682

Merged

karlhorky mentioned this pull request Jan 3, 2023

Feature request: allow user to merge extended arrays in tsconfig files #20110

Open

mklueh mentioned this pull request Jan 16, 2023

"Object literal may only specify known properties...'auth' does not exist in type 'NuxtConfig'" in nuxt.config.ts nuxt/nuxt#12386

Closed

This was referenced Feb 20, 2023

Figure out a way to proper support auto imports in editors cngJo/nuxt-turborepo#5

Closed

TypeScript 5: import .nuxt/tsconfig.json for nuxt apps cngJo/nuxt-turborepo#7

Open

dominikg mentioned this pull request Feb 23, 2023

feat: add support for ts 5 dominikg/tsconfck#80

Merged

JeremyMoeglich mentioned this pull request Mar 12, 2023

Support tsconfig extending multiple tsconfigs, typescript 5.0 sveltejs/kit#9412

Closed

johncmunson mentioned this pull request Mar 17, 2023

Overcoming the Need for TSConfig Multiple Inheritance NiGhTTraX/ts-monorepo#195

Closed

dpschen mentioned this pull request Mar 19, 2023

Enhancement: a dedicated config for libraries vuejs/tsconfig#5

Closed

kachick mentioned this pull request Apr 17, 2023

Welcome TypeScript 5 era kachick/action-typescript-template#287

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix(29118): tsconfig.extends as array #50403

Fix(29118): tsconfig.extends as array #50403

navya9singh commented Aug 22, 2022

sheetalkamat left a comment

sheetalkamat left a comment

RyanCavanaugh Aug 24, 2022

RyanCavanaugh Aug 24, 2022

RyanCavanaugh Aug 24, 2022

RyanCavanaugh Aug 29, 2022

sheetalkamat Nov 16, 2022

andrewbranch commented Dec 6, 2022

sheetalkamat commented Dec 6, 2022

andrewbranch commented Dec 6, 2022

sheetalkamat commented Dec 6, 2022

DanielRosenwasser commented Dec 7, 2022

typescript-bot commented Dec 7, 2022 •

edited

Loading

typescript-bot commented Dec 7, 2022 •

edited

Loading

andrewbranch commented Dec 12, 2022

andrewbranch left a comment

andrewbranch commented Dec 13, 2022

orta commented Dec 14, 2022

bradley-marker-ck commented Mar 31, 2023 •

edited

Loading

	if (option.element.type === "string"){
	if (option.element.type === "string") {

	Debug.fail();
	Debug.fail("listOrElement not supported here");

Fix(29118): tsconfig.extends as array #50403

Fix(29118): tsconfig.extends as array #50403

Conversation

navya9singh commented Aug 22, 2022

sheetalkamat left a comment

Choose a reason for hiding this comment

sheetalkamat left a comment

Choose a reason for hiding this comment

RyanCavanaugh Aug 24, 2022

Choose a reason for hiding this comment

RyanCavanaugh Aug 24, 2022

Choose a reason for hiding this comment

RyanCavanaugh Aug 24, 2022

Choose a reason for hiding this comment

RyanCavanaugh Aug 29, 2022

Choose a reason for hiding this comment

sheetalkamat Nov 16, 2022

Choose a reason for hiding this comment

andrewbranch commented Dec 6, 2022

sheetalkamat commented Dec 6, 2022

andrewbranch commented Dec 6, 2022

sheetalkamat commented Dec 6, 2022

DanielRosenwasser commented Dec 7, 2022

typescript-bot commented Dec 7, 2022 • edited Loading

typescript-bot commented Dec 7, 2022 • edited Loading

andrewbranch commented Dec 12, 2022

andrewbranch left a comment

Choose a reason for hiding this comment

andrewbranch commented Dec 13, 2022

orta commented Dec 14, 2022

bradley-marker-ck commented Mar 31, 2023 • edited Loading

typescript-bot commented Dec 7, 2022 •

edited

Loading

typescript-bot commented Dec 7, 2022 •

edited

Loading

bradley-marker-ck commented Mar 31, 2023 •

edited

Loading