-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix implied formats, file watching, new source file creating during edits #50098
Conversation
…report errors in watch mode
…one as part of create source file
…mplied format Also stop creating options if we already have them
…e. Handle implied node format in document registry Fixes #50086
…e to invalidate package json entries instead of clearing them out everytime program is created
@typescript-bot pack this |
Heya @sheetalkamat, I've started to run the tarball bundle task on this PR at 73f56b2. You can monitor the build here. |
Hey @sheetalkamat, I've packed this into an installable tgz. You can install it for testing by referencing it in your
and then running There is also a playground for this build and an npm module you can use via |
/*details*/ undefined, | ||
Diagnostics.File_redirects_to_file_0, | ||
toFileName(file.redirectInfo.redirectTarget, fileNameConvertor) | ||
)); | ||
} | ||
if (isExternalOrCommonJsModule(file)) { | ||
switch (file.impliedNodeFormat) { | ||
case ModuleKind.ESNext: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should both of these have a branch for when the file extension sets the format, for .cts
, .cjs
, .mjs
and .mts
files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DanielRosenwasser and myself discussed offline before this change and decided try this with only spitting this out when package.json determines the context.
This change includes:
--explainFiles
Fixes #50086