Remove portability error when emitting declarations for incremental mode

[weswigham]

Fixes #37960

[sheetalkamat]

I dont think we need this change.. The test case you have will give exact same result atleast with nightly with or without your change

[evelant]

@sheetalkamat This still seems to be an issue as of ts 4.8.3 when working with a pnpm mono repo.

[MaximSagan]

@weswigham Is there a blocker for getting this merged? There are still repos that are needing to patch TypeScript (as described in #37960) to get around this issue.

[sandersn]

@weswigham can you confirm whether this PR changes behavior with respect to main? Sounds like at least a couple of people are still seeing it.

[weswigham]

After looking into this again, I just don't think this is a good idea - while the declaration files for incremental aren't necessarily there to be shipped, they can be, and the original issue requestors weren't even using incremental in the first place. IMO, this error is just a known caveat of using incremental or composite (or declarations), and the correct fix is just doing what is asked in the error and adding an explicit type annotation at the indicated location (in so doing, you usually are forced to realize the transitive typing dependency yourself and choose how to resolve it!). If we ever swap our incremental metadata from declaration files to something less-human-consumable, maybe we can relax this rule then.