Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable method signature completion for object literals #48168

Merged
merged 38 commits into from
Mar 30, 2022
Merged

Enable method signature completion for object literals #48168

merged 38 commits into from
Mar 30, 2022

Commits on Feb 23, 2022

  1. skeleton of new feature

    @gabritto
    gabritto committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    41913b7 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2022

  1. working prototype

    @gabritto
    gabritto committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    d5038ce View commit details
    Browse the repository at this point in the history

  2. refactor print and format code into its own function

    @gabritto
    gabritto committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    fca74c1 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2022

  1. minor changes; don't support overloads

    @gabritto
    gabritto committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    249c3ba View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2022

  1. have two completion entries

    @gabritto
    gabritto committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    ef15f81 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2022

  1. get rid of accessor support

    @gabritto
    gabritto committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    1f26a52 View commit details
    Browse the repository at this point in the history

  2. add snippet support

    @gabritto
    gabritto committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    1c28090 View commit details
    Browse the repository at this point in the history

  3. add formatting

    @gabritto
    gabritto committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    e628590 View commit details
    Browse the repository at this point in the history

  4. add trailing comma

    @gabritto
    gabritto committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    515fc73 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2022

  1. add sourcedisplay

    @gabritto
    gabritto committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    0229a7d View commit details
    Browse the repository at this point in the history

  2. support auto-imports via completion details

    @gabritto
    gabritto committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    9892dc8 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2022

  1. add user preference option and fix ordering of entries

    @gabritto
    gabritto committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    8550bba View commit details
    Browse the repository at this point in the history

  2. cleanup

    @gabritto
    gabritto committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    78c7d9e View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2022

  1. don't return code actions for no import fixes

    @gabritto
    gabritto committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    1f67d97 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into gabritto/issue46590

    @gabritto
    gabritto committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    6c96290 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2022

  1. make sortText lower priority for snippets

    @gabritto
    gabritto committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    814561f View commit details
    Browse the repository at this point in the history

  2. get rid of flag

    @gabritto
    gabritto committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    088904e View commit details
    Browse the repository at this point in the history

  3. use optional member sort text

    @gabritto
    gabritto committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    4e63276 View commit details
    Browse the repository at this point in the history

  4. update baselines

    @gabritto
    gabritto committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    474d9a9 View commit details
    Browse the repository at this point in the history

  5. don't collect method symbols if insert text is not supported

    @gabritto
    gabritto committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    b5d05c0 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2022

  1. remove comment

    @gabritto
    gabritto committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    6914576 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2022

  1. return undefined if type is not function type

    @gabritto
    gabritto committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    0e0ae05 View commit details
    Browse the repository at this point in the history

  2. only slice if needed

    @gabritto
    gabritto committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    36eac73 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2022

  1. use union reduction; more test cases

    @gabritto
    gabritto committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    b9cb703 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2022

  1. WIP: modify sort text system

    @gabritto
    gabritto committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    7c9cbdb View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2022

  1. Improve new sort text system

    @gabritto
    gabritto committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    07c4fcf View commit details
    Browse the repository at this point in the history

  2. add signature and union type check

    @gabritto
    gabritto committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    5b0d86d View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2022

  1. Merge branch 'main' into gabritto/issue46590

    @gabritto
    gabritto committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    b032aa5 View commit details
    Browse the repository at this point in the history

  2. re-add flag

    @gabritto
    gabritto committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    08a55c3 View commit details
    Browse the repository at this point in the history

  3. fix tests

    @gabritto
    gabritto committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    6ebe361 View commit details
    Browse the repository at this point in the history

  4. rename sort text helper

    @gabritto
    gabritto committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    411bc18 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2022

  1. fix test and code for union case

    @gabritto
    gabritto committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    1ebdf3d View commit details
    Browse the repository at this point in the history

  2. add new flag to protocol type

    @gabritto
    gabritto committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    5477408 View commit details
    Browse the repository at this point in the history

  3. fix spaces

    @gabritto
    gabritto committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    af7de76 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2022

  1. CR: minor fixes

    @gabritto
    gabritto committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    1b884c4 View commit details
    Browse the repository at this point in the history

  2. CR: more fixes

    @gabritto
    gabritto committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    3820f32 View commit details
    Browse the repository at this point in the history

  3. CR: restructure main flow

    @gabritto
    gabritto committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    e7a51e6 View commit details
    Browse the repository at this point in the history

  4. minor fix

    @gabritto
    gabritto committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    203aab0 View commit details
    Browse the repository at this point in the history