Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(7410): Support JSX Element as JSX Attribute Value #47994

Merged
merged 1 commit into from
May 11, 2022

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #7410

JSXAttributeValue:
    " JSXDoubleStringCharactersopt "
    ' JSXSingleStringCharactersopt '
    { AssignmentExpression }
    JSXElement
    JSXFragment

@RyanCavanaugh
Copy link
Member

Waiting for final confirmation on facebook/jsx#53 before merging/closing.

src/compiler/types.ts Outdated Show resolved Hide resolved
@RyanCavanaugh
Copy link
Member

@raghavthind2005 bulk-"approving" changes like what you're doing here is a little spammy; please refrain from doing this

@sandersn
Copy link
Member

sandersn commented May 9, 2022

@RyanCavanaugh are we still waiting on confirmation from facebook/jsx to merge this?

@RyanCavanaugh
Copy link
Member

Maybe let's just merge it. If the JSX spec changes, we'll have the same mess to clean up as Babel, which is fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support JSX Element as JSX Attribute Value
6 participants