Code

ES private field check#44648

Code

Merged

sandersn merged 45 commits intomicrosoft:mainmicrosoft/TypeScript:mainfrom bloomberg:private-fields-in-inbloomberg/TypeScript:private-fields-in-inCopy head branch name to clipboardSep 24, 2021

+2,398-45

Commits

Commits on Jun 17, 2021

• es private fields in in (#52)

  Show description for f04f22c
  acutmore

  authored
  f04f22c

  Copy full SHA for f04f22c

Commits on Jun 18, 2021

• [fixup] include inToken when walking forEachChild(node, cb)

  acutmore

  committed
  30dde52

  Copy full SHA for 30dde52

• Merge remote-tracking branch 'origin/main' into bb-private-field-in-in

  acutmore

  committed
  31fa02b

  Copy full SHA for 31fa02b

Commits on Jun 30, 2021

• Merge remote-tracking branch 'origin/main' into bb-private-field-in-in

  acutmore

  committed
  307247c

  Copy full SHA for 307247c

• [squash] re-accept lib definition baseline changes

  acutmore

  committed
  61c677b

  Copy full SHA for 61c677b

Commits on Sep 15, 2021

• [squash] reduce if/else to ternary

  Show description for 8292ee2
  acutmore

  committed
  8292ee2

  Copy full SHA for 8292ee2

• [squash] drop 'originalName' and rename parameter instead

  Show description for 4723380
  acutmore

  committed
  4723380

  Copy full SHA for 4723380

• [squash] extend spelling suggestion to all privateIdentifiers

  Show description for 9f1c176
  acutmore

  committed
  9f1c176

  Copy full SHA for 9f1c176

Commits on Sep 16, 2021

• [squash] revert the added lexical spelling suggestions logic

  Show description for 511ac22
  acutmore

  committed
  511ac22

  Copy full SHA for 511ac22

• [squash] update baseline

  Show description for 337f7e8
  acutmore

  committed
  337f7e8

  Copy full SHA for 337f7e8

• [squash] inline variable as per PR suggestion

  Show description for d059c15
  acutmore

  committed
  d059c15

  Copy full SHA for d059c15

• [squash] test targets both esnext and es2020 as per PR comment

  Show description for 79eeebe
  acutmore

  committed
  79eeebe

  Copy full SHA for 79eeebe

Commits on Sep 17, 2021

• switch to using a binary expression

  Show description for 125df93
  acutmore

  committed
  125df93

  Copy full SHA for 125df93

• Merge remote-tracking branch 'origin/main' into private-field-in-in

  acutmore

  committed
  c6b2a21

  Copy full SHA for c6b2a21

• [squash] PrivateIdentifier now extends PrimaryExpression

  Show description for 320bc00
  acutmore

  committed
  320bc00

  Copy full SHA for 320bc00

• [squash] accept public api baseline changes

  Show description for cc80c7d
  acutmore

  committed
  cc80c7d

  Copy full SHA for cc80c7d

• [squash] classPrivateFieldInHelper now has documentation

  Show description for ebbb063
  acutmore

  committed
  ebbb063

  Copy full SHA for ebbb063

Commits on Sep 20, 2021

• [squash] type-check now follows existing in-expression path

  Show description for ea4fd4b
  acutmore

  committed
  ea4fd4b

  Copy full SHA for ea4fd4b

• [squash] parser now follows existing binaryExpression path

  Show description for 8b78f01
  acutmore

  committed
  8b78f01

  Copy full SHA for 8b78f01

Commits on Sep 21, 2021

• [squash] correct typo in comment

  Show description for 01c7042
  acutmore

  committed
  01c7042

  Copy full SHA for 01c7042

• [squash] no longer use esNext flag

  Show description for fc2b262
  acutmore

  committed
  fc2b262

  Copy full SHA for fc2b262

• [squash] swap 'reciever, state' helper params

  Show description for c007a12
  acutmore

  committed
  c007a12

  Copy full SHA for c007a12

• [squash] remove change to parenthesizerRules

  Show description for 40bd336
  acutmore

  committed
  40bd336

  Copy full SHA for 40bd336

• [squash] apply suggested changes to checker

  Show description for 7982164
  acutmore

  committed
  7982164

  Copy full SHA for 7982164

• [squash] remove need for assertion in fixSpelling

  Show description for 1cd313f
  acutmore

  committed
  1cd313f

  Copy full SHA for 1cd313f

• [squash] improve comment hint in test

  Show description for 97f7d30
  acutmore

  committed
  97f7d30

  Copy full SHA for 97f7d30

Commits on Sep 22, 2021

• [squash] fix comment typos

  Show description for e672957
  acutmore

  committed
  e672957

  Copy full SHA for e672957

• [squash] add flow-test for Foo | FooSub | Bar

  Show description for 2b7425d
  acutmore

  committed
  2b7425d

  Copy full SHA for 2b7425d

• [squash] add checkExternalEmitHelpers call and new test case

  Show description for 52b9f2a
  acutmore

  committed
  52b9f2a

  Copy full SHA for 52b9f2a

• [squash] simplify and correct parser

  Show description for 476bf24
  acutmore

  committed
  476bf24

  Copy full SHA for 476bf24

• [squash] move most of the added checker logic to expression level

  Show description for be26d0a
  acutmore

  committed
  be26d0a

  Copy full SHA for be26d0a

• [squash] always error when privateId could not be resolved

  Show description for f7ddce5
  acutmore

  committed
  f7ddce5

  Copy full SHA for f7ddce5

• [squash] reword comment

  Show description for 01e0e60
  acutmore

  committed
  01e0e60

  Copy full SHA for 01e0e60

• [squash] fix codeFixSpelling test

  Show description for 913d044
  acutmore

  committed
  913d044

  Copy full SHA for 913d044

• [squash] do less work

  Show description for 7c49552
  acutmore

  committed
  7c49552

  Copy full SHA for 7c49552

Commits on Sep 23, 2021

• store symbol by priateId not binaryExpression

  Show description for c6b039f
  acutmore

  committed
  c6b039f

  Copy full SHA for c6b039f

• moved parsePrivateIdentifier into parsePrimaryExpression

  Show description for 6f56c6a
  acutmore

  committed
  6f56c6a

  Copy full SHA for 6f56c6a

• [squash] checkInExpressionn bails out early on silentNeverType

  Show description for c3b6c2a
  acutmore

  committed
  c3b6c2a

  Copy full SHA for c3b6c2a

• [squash] more detailed error messages

  Show description for 5fbb2da
  acutmore

  committed
  5fbb2da

  Copy full SHA for 5fbb2da

• [squash] resolves conflict in diagnosticMessages.json

  Show description for c924a51
  acutmore

  committed
  c924a51

  Copy full SHA for c924a51

• Merge remote-tracking branch 'origin/main' into private-field-in-in-binary-expression

  acutmore

  committed
  27d494d

  Copy full SHA for 27d494d

• [squash] update baseline for importHelpersES6

  Show description for 33c3b55
  acutmore

  committed
  33c3b55

  Copy full SHA for 33c3b55

• [squash] remove redundent if and comment from parser

  Show description for e3c25c9
  acutmore

  committed
  e3c25c9

  Copy full SHA for e3c25c9

• [squash] split up grammar/check/symbolLookup

  Show description for 74e56a6
  acutmore

  committed
  74e56a6

  Copy full SHA for 74e56a6

• [squash] reword message for existing left side of in-expression error

  Show description for 8447934
  acutmore

  committed
  8447934

  Copy full SHA for 8447934