Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contextual discrimination for omitted members #43937

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Fix contextual discrimination for omitted members #43937

merged 1 commit into from
Mar 4, 2022

Commits on May 3, 2021

  1. Fix contextual discrimination for omitted members

    In short, the fix I submitted looked at the union ofproperties, but it
    really should have looked at the intersection.
    
    Two sytlistic notes. I couldn't find the best way to get the unique
    strings of an array like `[...new Set()]` would, so I created a small
    helper function, but didn't put it in a great place. Also, before the
    second concatenated array of discriminators at least matched the first
    in complexity, but now it's much worse. I don't think that section is
    particularly easy to read, but I also don't see a significantly reusable
    part.
    
    fixes #41759
    erikbrinkman committed May 3, 2021
    Configuration menu
    Copy the full SHA
    8b3588d View commit details
    Browse the repository at this point in the history