Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gh 41788 incorrect output for esprivate with nested class in esnext #42663

Merged
merged 7 commits into from
Apr 7, 2021
Merged

Gh 41788 incorrect output for esprivate with nested class in esnext #42663

merged 7 commits into from
Apr 7, 2021

Commits on Apr 5, 2021

  1. If target:esnext,then useDefineForClassFields: true will now be the d… 

    …efault.
    @dragomirtitian
    dragomirtitian committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    dc5d50e View commit details
    Browse the repository at this point in the history

  2. Added error if a private identifier is used in a static a initializer… 

    … if target:ESNext and useDefineForClassFields:false.
    @dragomirtitian
    dragomirtitian committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    7809099 View commit details
    Browse the repository at this point in the history

  3. Added test for new useDefineForClassFields default and error message.

    @dragomirtitian
    dragomirtitian committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    b3021b2 View commit details
    Browse the repository at this point in the history

  4. Fixed tests after changing the default of useDefineForClassFields to … 

    …true for target esnext
    @dragomirtitian
    dragomirtitian committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    ce875d4 View commit details
    Browse the repository at this point in the history

  5. Fixed code review suggestions.

    @dragomirtitian
    dragomirtitian committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    d1f480f View commit details
    Browse the repository at this point in the history

  6. Updated error message.

    @dragomirtitian
    dragomirtitian committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    a29bcb0 View commit details
    Browse the repository at this point in the history

  7. Added missing static check for the containing property. Fixed other c… 

    …ode review issues.
    @dragomirtitian
    dragomirtitian committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    dc0a347 View commit details
    Browse the repository at this point in the history