Fix dependency order and observer registration #41253
Conversation
typescript-bot
added
Author: Team
For Uncommitted Bug
| @@ -84,7 +84,7 @@ namespace ts { | |||
| performance.mark(end); | |||
| } | |||
| performance.measure(name, start, end); | |||
| if (end = "__performance.measure-fix__") { | |||
There was a problem hiding this comment.
Hm... Should we have a lint for this?
There was a problem hiding this comment.
Or a --strictBoolean (or --pedanticBoolean?) flag that requires all conditions be boolean (including !). It wouldn't catch if (f = true), but it also would mean you'd have to write a lot of if (obj !== null && obj !== undefined) instead of if (obj) because !!obj would also be a violation...
There was a problem hiding this comment.
while (next = read()) seems like a sane pattern, so this feels more like a heuristic than a compiler error. Having said that, I would probably personally use such a mode, assuming it had a (totally reasonable) exception for !!expr.
There was a problem hiding this comment.
I mean, mostly just using = in an if without a reference to the assigned variable within the if. (Since I know we do this intentionally in relationship checking, but the difference there is we actually reference the checked variable)
| @@ -13,10 +13,10 @@ | |||
| "corePublic.ts", | |||
| "core.ts", | |||
| "debug.ts", | |||
| "semver.ts", | |||
There was a problem hiding this comment.
Does this need a comment so it doesn't get alphabetized back?
There was a problem hiding this comment.
These should never be alphabetized, they are all order dependent.
Fixes a dependency ordering issue in #40593 and correctly handles that PerformanceObserver's callback is called each time a mark or measure is recorded, not just once.
These issues were detected when running perf tests on another PR.