Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow private symbols to be control flow narrowed #39978

Merged
merged 5 commits into from
Sep 5, 2020

Conversation

weswigham
Copy link
Member

Fixes #39960

@DanielRosenwasser
Copy link
Member

While I trust the change, I'm going to say that without more than a week of testing, we should probably just err on the safe side and make this 4.1-bound at best.

@weswigham
Copy link
Member Author

Ping for reviewers - @DanielRosenwasser and @ahejlsberg - we're in the 4.1 era now~

Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one formatting request.

src/compiler/checker.ts Outdated Show resolved Hide resolved
@weswigham weswigham merged commit e5fd0dd into microsoft:master Sep 5, 2020
@weswigham weswigham deleted the private-symbol-control-flow branch September 5, 2020 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Class property inference from constructor does not work with private class fields
5 participants