Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jsxFragmentFactory entity name for factory name lookup from checking fragments #39475

Merged

Conversation

weswigham
Copy link
Member

@weswigham weswigham commented Jul 7, 2020

Fixes #39451

@weswigham weswigham force-pushed the jsxfragmentfactory-no-unused branch from 947a798 to a42dd9d Compare July 7, 2020 21:33
@weswigham weswigham requested a review from sandersn July 7, 2020 21:33
Copy link
Member

@DanielRosenwasser DanielRosenwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems consistent, maybe just get eyes from @RyanCavanaugh on it though.

@weswigham weswigham requested a review from RyanCavanaugh July 8, 2020 20:33
@DanielRosenwasser DanielRosenwasser merged commit ef9affe into microsoft:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TS 4.0: jsxFragmentFactory ignored in Preact + TypeScript setup
4 participants