Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(33511): React Native <Text> component quick fix weird import suggestion #38419

Merged
merged 1 commit into from
Jul 14, 2020
Merged

fix(33511): React Native <Text> component quick fix weird import suggestion #38419

merged 1 commit into from
Jul 14, 2020

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #33511

sandersn
sandersn approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks OK, but I don't understand how the old code was broken. Can you explain?

src/services/codefixes/importFixes.ts Show resolved Hide resolved
@sandersn sandersn added the For Backlog Bug PRs that fix a backlog bug label Jun 1, 2020
@a-tarasyuk a-tarasyuk force-pushed the bug/33511 branch 2 times, most recently from ac1aa5d to 95b1330 Compare June 2, 2020 17:57
@a-tarasyuk a-tarasyuk requested a review from sandersn July 4, 2020 14:35
@a-tarasyuk a-tarasyuk force-pushed the bug/33511 branch 3 times, most recently from a669b28 to f2aade6 Compare July 12, 2020 16:53
sandersn
sandersn approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bearing with my questions! And sorry I let this sit for so long.

@sandersn sandersn merged commit ececf3b into microsoft:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

Assignees
No one assigned
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

React Native <Text> component quick fix weird import suggestion
2 participants
@a-tarasyuk @sandersn