Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix declaration emit when the packages are included through symlinks #37438

Merged
merged 6 commits into from
Mar 17, 2020

Conversation

sheetalkamat
Copy link
Member

@sheetalkamat sheetalkamat commented Mar 17, 2020

  • Earlier when looking at the redirects, we didnt use Path which is the key so in cases of symlink having different cases, we were not including the redirects resulting in the errors during decl emit
    Fixes Type resolution in linked packages - Updated Repro #36866
  • Converted symlink tests to virtualFileSystemWithWatch since mounting fs used in tscwatch baseline scenarios did not preserve symlinks correctly.
  • So when doing that realised that one of the test case where package is included as a dependency of package included, we werent reporting error as expected. (It worked earlier because symlink realpath always came out to be same as actual path instead of translating to actual path during mounting of fs scenarios) To fix this, exclude paths that dont have node_modules if any of the paths for the given module is through node_modules
  • Refactored ModuleSpecifierResolutionHost which shouldn't have been in Public API

src/services/utilities.ts Outdated Show resolved Hide resolved
src/compiler/moduleSpecifiers.ts Show resolved Hide resolved
src/compiler/moduleSpecifiers.ts Show resolved Hide resolved
Co-Authored-By: Andrew Branch <andrewbranch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type resolution in linked packages - Updated Repro
4 participants