Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add union of replacer function and string #34941

Closed
wants to merge 2 commits into from
Closed

Add union of replacer function and string #34941

wants to merge 2 commits into from

Conversation

marcin-serwin
Copy link
Contributor

Fixes #29789

@sandersn sandersn added the For Backlog Bug PRs that fix a backlog bug label Feb 3, 2020
@sandersn sandersn self-assigned this Mar 10, 2020
@orta orta closed this May 31, 2021
@orta orta deleted the branch microsoft:master May 31, 2021 09:44
@orta
Copy link
Contributor

orta commented May 31, 2021

Hi @marcin-serwin - this PR didn't have 'allow maintainers to make changes' checked, and so when we migrated TypeScript's primary branch from 'master' to 'main' this PR couldn't have its branch re-targeted.

It looks like we've not quite pushed this PR over the line (IMO, that's on us the TypeScript team, not you) - I'm running the tests on a new PR which replicates your work and is up-to-date. Will link that to this when that's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

.call selects the wrong overload for String.prototype.replace
3 participants