refactor(spelling): correct misspelled response

[sQVe]

This PR fixes a spelling mistake introduced with 8004fec.

[typescript-bot]

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @amcasey, @mjbvz, @minestarks for you. Feel free to loop in other consumers/maintainers if necessary

[msftclas]

All CLA requirements met.

[amcasey]

It looks like this has, unfortunately, already shipped, so we probably have to keep the misspelled one for back compat. I'm guessing the preferred approach is to add the new one with correct spelling and flag the old one as deprecated. @sheetalkamat?

[sheetalkamat]

I'm guessing the preferred approach is to add the new one with correct spelling and flag the old one as deprecated

Yes that's the way we would need to handle this change.

[sQVe]

@amcasey, @sheetalkamat: Could you possibly point me in the right direction on how to make this change but also keep backwards compatibility?

[mjbvz]

Looks like this only touches a type name and not the protocol itself, so do we really need to worry about breaking things? The change maybe cause a compile error but I think server would still work if you use the old misspelled type name

[sQVe]

export interface DefinitionInfoAndBoundSpanResponse extends Response {
    body?: DefinitionInfoAndBoundSpan;
}

/**
 * @deprecated
 */
export interface DefinitionInfoAndBoundSpanReponse extends DefinitionInfoAndBoundSpanResponse {}

Would something like the above suffice?

[amcasey]

@mjbvz I agree that it should still work at runtime, but I think we prefer to avoid compiler errors as well.

@sQVe My naive guess would have been type DefinitionInfoAndBoundSpanReponse = DefinitionInfoAndBoundSpanResponse; to alias the type, but @sheetalkamat would know better.

[sheetalkamat]

/** @deprecated Use `DefinitionInfoAndBoundSpanResponse` instead.  */
export type DefinitionInfoAndBoundSpanReponse = DefinitionInfoAndBoundSpanResponse ;

[sQVe]

@amcasey, @sheetalkamat: Backwards compability is now added. I made the assumption that I could leave the tests untouched and just use the new correctly named type.

[sQVe]

Unsure on how to make the tests pass.

 61508 passing (2m)
  1 failing

  1)

         Public APIs
           for the language server
             should be acknowledged when they change:
     Error: The baseline file api/tsserverlibrary.d.ts has changed.

Above is not much to go on.

[sheetalkamat]

You need to run gulp runtests --t="Public API" and then gulp baseline-accept and commit the change in the baseline.

[amcasey]

LGTM once the tests pass. Thanks!

[sQVe]

Got the tests to pass and squashed commits into one. I think this is ready for a merge now. 🙏