Code

Convert to named parameters#30089

Code

Merged

gabritto merged 57 commits intomastermicrosoft/TypeScript:masterfrom convert-to-named-parametersmicrosoft/TypeScript:convert-to-named-parametersCopy head branch name to clipboardMar 6, 2019

+1,387-80

Commits

Commits on Jan 16, 2019

• create refactoring for converting to named parameters

  

  Gabriela Britto

  committed
  9aeeae5

  Copy full SHA for 9aeeae5

• WIP

  

  Gabriela Britto

  committed
  705ac60

  Copy full SHA for 705ac60

Commits on Jan 17, 2019

• implement new parameter creation

  

  Gabriela Britto

  committed
  23fc65a

  Copy full SHA for 23fc65a

Commits on Jan 19, 2019

• implement new parameter creation

  

  Gabriela Britto

  committed
  919ed79

  Copy full SHA for 919ed79

• add test for convert to named parameters refactoring

  

  Gabriela Britto

  committed
  bd290e6

  Copy full SHA for bd290e6

Commits on Jan 28, 2019

• Move function getTypeNodeIfAccessible from inferFromUsage to utilities

  

  Gabriela Britto

  committed
  f3e60be

  Copy full SHA for f3e60be

• Refactor direct function calls

  

  Gabriela Britto

  committed
  3243b4b

  Copy full SHA for 3243b4b

• Add tests for convert to named parameters refactor

  

  Gabriela Britto

  committed
  b668e34

  Copy full SHA for b668e34

Commits on Jan 29, 2019

• Merge branch 'master' into convert-to-named-parameters

  

  Gabriela Britto

  committed
  9e62eb9

  Copy full SHA for 9e62eb9

Commits on Jan 30, 2019

• preserve this parameter when refactoring

  

  Gabriela Britto

  committed
  1d94322

  Copy full SHA for 1d94322

• update tests formatting

  

  Gabriela Britto

  committed
  050c70a

  Copy full SHA for 050c70a

• add tests

  

  Gabriela Britto

  committed
  40987ec

  Copy full SHA for 40987ec

Commits on Feb 1, 2019

• Don't refactor if variable declaration has type annotation

  

  Gabriela Britto

  committed
  bf25ba4

  Copy full SHA for bf25ba4

Commits on Feb 2, 2019

• fix refactor to find super references

  

  Gabriela Britto

  committed
  bde97d1

  Copy full SHA for bde97d1

• add more tests

  

  Gabriela Britto

  committed
  abb1155

  Copy full SHA for abb1155

Commits on Feb 4, 2019

• implement refactor for functions with a rest parameter

  

  Gabriela Britto

  committed
  674800f

  Copy full SHA for 674800f

• add tests for rest parameters

  

  Gabriela Britto

  committed
  1d1c820

  Copy full SHA for 1d1c820

Commits on Feb 6, 2019

• add option to suppressLeadingAndTrailingTrivia non recursively

  

  Gabriela Britto

  committed
  18b2b55

  Copy full SHA for 18b2b55

• fix duplication of leading and trailing comments on refactored function

  

  Gabriela Britto

  committed
  b87392c

  Copy full SHA for b87392c

• Merge branch 'master' into convert-to-named-parameters

  

  Gabriela Britto

  committed
  9270e58

  Copy full SHA for 9270e58

Commits on Feb 7, 2019

• fix hasThisParameter to check for parameters length

  

  Gabriela Britto

  committed
  7d86fda

  Copy full SHA for 7d86fda

Commits on Feb 11, 2019

• create functions for copying trailing comments and rename previous copyComment function

  

  Gabriela Araujo Britto

  committed
  26f8ddd

  Copy full SHA for 26f8ddd

• copy comments when refactoring

  

  Gabriela Araujo Britto

  committed
  dba631d

  Copy full SHA for dba631d

• add tests for comments

  

  Gabriela Araujo Britto

  committed
  4e135f1

  Copy full SHA for 4e135f1

• don't apply refactor when parameter has decorators

  

  Gabriela Araujo Britto

  committed
  dbd8499

  Copy full SHA for dbd8499

Commits on Feb 13, 2019

• don't apply changes when unexpected reference is found

  

  Gabriela Araujo Britto

  committed
  ef4db31

  Copy full SHA for ef4db31

• return function expression name in getFunctionDeclarationNames

  

  Gabriela Araujo Britto

  committed
  ec0e734

  Copy full SHA for ec0e734

• fix reference checking

  

  Gabriela Araujo Britto

  committed
  05e9d6c

  Copy full SHA for 05e9d6c

Commits on Feb 15, 2019

• rename refactor tests

  

  Gabriela Araujo Britto

  committed
  b93afff

  Copy full SHA for b93afff

• create new ConfigurableStart and ConfigurableEnd options and rename them

  

  Gabriela Araujo Britto

  committed
  eef3da5

  Copy full SHA for eef3da5

• replace argument list instead of whole call when refactoring

  

  Gabriela Araujo Britto

  committed
  b6c8382

  Copy full SHA for b6c8382

Commits on Feb 16, 2019

• copy argument comments to property

  

  Gabriela Araujo Britto

  committed
  a773046

  Copy full SHA for a773046

Commits on Feb 19, 2019

• don't provide refactor in js file

  

  Gabriela Araujo Britto

  committed
  78968b1

  Copy full SHA for 78968b1

• include trailing trivia after expression in getAdjustedEndPosition if endPosition is include

  

  Gabriela Araujo Britto

  committed
  17b8965

  Copy full SHA for 17b8965

• add tests for inherited constructor and method

  

  Gabriela Araujo Britto

  committed
  edf0cec

  Copy full SHA for edf0cec

• refactor expected test output

  

  Gabriela Araujo Britto

  committed
  754f4a4

  Copy full SHA for 754f4a4

Commits on Feb 20, 2019

• minor refactors

  

  Gabriela Araujo Britto

  committed
  e40442d

  Copy full SHA for e40442d

• Merge branch 'master' into convert-to-named-parameters

  

  Gabriela Araujo Britto

  committed
  6b53489

  Copy full SHA for 6b53489

Commits on Feb 23, 2019

• check usages of class if refactoring a constructor

  

  Gabriela Araujo Britto

  committed
  ce42aa4

  Copy full SHA for ce42aa4

• fix comment

  

  Gabriela Araujo Britto

  committed
  640424e

  Copy full SHA for 640424e

Commits on Feb 25, 2019

• update failing tests

  

  Gabriela Araujo Britto

  committed
  bc3611d

  Copy full SHA for bc3611d

• add new tests for bad class references

  

  Gabriela Araujo Britto

  committed
  f571866

  Copy full SHA for f571866

• Merge branch 'master' into convert-to-named-parameters

  

  Gabriela Araujo Britto

  committed
  365967d

  Copy full SHA for 365967d

• add tests

  

  Gabriela Araujo Britto

  committed
  a5153a9

  Copy full SHA for a5153a9

Commits on Feb 26, 2019

• change startPosition and endPosition to leadingTriviaOption and trailingTriviaOption

  

  Gabriela Araujo Britto

  committed
  e3a465f

  Copy full SHA for e3a465f

• don't export useNonAjustedPositions

  

  Gabriela Araujo Britto

  committed
  bf5123d

  Copy full SHA for bf5123d

• remove unused LeadingTriviaOption and TrailingTriviaOption options

  

  Gabriela Araujo Britto

  committed
  970ec62

  Copy full SHA for 970ec62

Commits on Feb 27, 2019

• refactor utilities

  

  Gabriela Araujo Britto

  committed
  006fe14

  Copy full SHA for 006fe14

Commits on Feb 28, 2019

• refactor getGroupReferences

  

  Gabriela Araujo Britto

  committed
  54c7996

  Copy full SHA for 54c7996

• minor refactors to convertToNamedParameters

  

  Gabriela Araujo Britto

  committed
  7fd6868

  Copy full SHA for 7fd6868

• use sortAndDeduplicate instead of deduplicate

  

  Gabriela Araujo Britto

  committed
  51616a4

  Copy full SHA for 51616a4

• add diagnostics message for refactor description

  

  Gabriela Araujo Britto

  committed
  617d5af

  Copy full SHA for 617d5af

Commits on Mar 1, 2019

• remove inlineable

  

  Gabriela Araujo Britto

  committed
  1f91aa1

  Copy full SHA for 1f91aa1

• use interface for ValidVariableDeclaration

  

  Gabriela Araujo Britto

  committed
  cd060e7

  Copy full SHA for cd060e7

• use getTouchingToken

  

  Gabriela Araujo Britto

  committed
  98a146d

  Copy full SHA for 98a146d

Commits on Mar 4, 2019

• add test for non-transient symbol

  

  Gabriela Araujo Britto

  committed
  8c4ab69

  Copy full SHA for 8c4ab69

Commits on Mar 6, 2019

• remove unnecessary closures

  

  Gabriela Araujo Britto

  committed
  60b2d6a

  Copy full SHA for 60b2d6a