Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix definitely assignable relation #28718

Merged
merged 3 commits into from
Nov 29, 2018
Merged

Fix definitely assignable relation #28718

merged 3 commits into from
Nov 29, 2018

Conversation

ahejlsberg
Copy link
Member

Fixes #28654.

weswigham
weswigham approved these changes Nov 29, 2018
View reviewed changes
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose not including the unsound index constraint assignability rule in definitely assignable is better than doing so.

@ahejlsberg ahejlsberg merged commit 36dc04b into master Nov 29, 2018
@DanielRosenwasser DanielRosenwasser deleted the fixDefinitelyAssignableRelation branch November 29, 2018 02:30
@jack-williams jack-williams mentioned this pull request Dec 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahejlsberg @weswigham