Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caches the recursive directory watchers so we do not have to traverse and recreate more children watches #25464

Merged
merged 2 commits into from
Jul 10, 2018
Merged

Caches the recursive directory watchers so we do not have to traverse and recreate more children watches #25464

merged 2 commits into from
Jul 10, 2018

Conversation

sheetalkamat
Copy link
Member

Helps with #25018

@sheetalkamat sheetalkamat force-pushed the cacheRecursiveDirectoryWatchers branch from e8e6c08 to 9c6c333 Compare July 5, 2018 23:06
@sheetalkamat sheetalkamat requested a review from mhegazy July 6, 2018 18:07
@sheetalkamat
Copy link
Member Author

@mhegazy can you please review this. This change caches the recursive directory watchers so we arent going through asking disk about directory structure and adding watch on them when watching same or child directory of already watching directory.

@sheetalkamat sheetalkamat merged commit c50407e into master Jul 10, 2018
@sheetalkamat sheetalkamat deleted the cacheRecursiveDirectoryWatchers branch July 10, 2018 22:30
@sheetalkamat sheetalkamat mentioned this pull request Jul 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhegazy mhegazy mhegazy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sheetalkamat @mhegazy