Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 User test baselines have changed #25294

Merged
merged 1 commit into from
Jun 28, 2018
+337 −214
Merged

🤖 User test baselines have changed #25294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/baselines/reference/user/TypeScript-Node-Starter.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Exit Code: 1
Standard output:
node_modules/@types/passport-facebook/index.d.ts(50,31): error TS2689: Cannot extend an interface 'passport.Strategy'. Did you mean 'implements'?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andy-ms, can you take a look at what happened here?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this with a fresh npm install. Do you know what command the bot runs?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm i --no-save --ignore-scripts

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did:

  • jake clean
  • jake local
  • git submodule update tests/cases/user/TypeScript-Node-Starter/
  • cd tests/cases/user/TypeScript-Node-Starter/TypeScript-Node-Starter
  • rm -r node_modules
  • npm i --no-save --ignore-scripts
  • node ../../../../../built/local/tsc.js

I see compile errors in mocha, jquery, and lodash. @types/passport-facebook is installed but I don't see any compile errors there.




Standard error:
3 changes: 2 additions & 1 deletion tests/baselines/reference/user/assert.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ node_modules/assert/assert.js(394,51): error TS2339: Property 'notStrictEqual' d
node_modules/assert/assert.js(473,8): error TS2339: Property 'throws' does not exist on type '(value: any, message: any) => void'.
node_modules/assert/assert.js(478,8): error TS2339: Property 'doesNotThrow' does not exist on type '(value: any, message: any) => void'.
node_modules/assert/assert.js(482,8): error TS2339: Property 'ifError' does not exist on type '(value: any, message: any) => void'.
node_modules/assert/test.js(25,5): error TS2365: Operator '===' cannot be applied to types 'string | undefined' and 'boolean'.
node_modules/assert/test.js(25,5): error TS2367: The types of these values indicate that this condition will always be 'false'.
Operator '===' cannot be applied to types 'string | undefined' and 'boolean'.
node_modules/assert/test.js(39,5): error TS2552: Cannot find name 'test'. Did you mean 'tests'?
node_modules/assert/test.js(55,5): error TS2552: Cannot find name 'test'. Did you mean 'tests'?
node_modules/assert/test.js(74,5): error TS2552: Cannot find name 'test'. Did you mean 'tests'?
Expand Down
15 changes: 10 additions & 5 deletions tests/baselines/reference/user/bluebird.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,18 @@ node_modules/bluebird/js/release/async.js(94,21): error TS2300: Duplicate identi
node_modules/bluebird/js/release/async.js(96,21): error TS2300: Duplicate identifier 'invokeLater'.
node_modules/bluebird/js/release/async.js(108,21): error TS2300: Duplicate identifier 'invoke'.
node_modules/bluebird/js/release/async.js(118,21): error TS2300: Duplicate identifier 'settlePromises'.
node_modules/bluebird/js/release/bluebird.js(5,15): error TS2365: Operator '===' cannot be applied to types 'PromiseConstructor' and 'typeof Promise'.
node_modules/bluebird/js/release/bluebird.js(5,15): error TS2367: The types of these values indicate that this condition will always be 'false'.
Operator '===' cannot be applied to types 'PromiseConstructor' and 'typeof Promise'.
node_modules/bluebird/js/release/bluebird.js(10,10): error TS2339: Property 'noConflict' does not exist on type 'typeof Promise'.
node_modules/bluebird/js/release/catch_filter.js(27,28): error TS2349: Cannot invoke an expression whose type lacks a call signature. Type '((o: {}) => string[]) | ((o: any) => string[])' has no compatible call signatures.
node_modules/bluebird/js/release/debuggability.js(18,20): error TS2365: Operator '!=' cannot be applied to types 'string | undefined' and 'number'.
node_modules/bluebird/js/release/debuggability.js(23,19): error TS2365: Operator '!=' cannot be applied to types 'string | undefined' and 'number'.
node_modules/bluebird/js/release/debuggability.js(26,26): error TS2365: Operator '!=' cannot be applied to types 'string | undefined' and 'number'.
node_modules/bluebird/js/release/debuggability.js(29,24): error TS2365: Operator '!=' cannot be applied to types 'string | undefined' and 'number'.
node_modules/bluebird/js/release/debuggability.js(18,20): error TS2367: The types of these values indicate that this condition will always be 'true'.
Operator '!=' cannot be applied to types 'string | undefined' and 'number'.
node_modules/bluebird/js/release/debuggability.js(23,19): error TS2367: The types of these values indicate that this condition will always be 'true'.
Operator '!=' cannot be applied to types 'string | undefined' and 'number'.
node_modules/bluebird/js/release/debuggability.js(26,26): error TS2367: The types of these values indicate that this condition will always be 'true'.
Operator '!=' cannot be applied to types 'string | undefined' and 'number'.
node_modules/bluebird/js/release/debuggability.js(29,24): error TS2367: The types of these values indicate that this condition will always be 'true'.
Operator '!=' cannot be applied to types 'string | undefined' and 'number'.
node_modules/bluebird/js/release/debuggability.js(160,17): error TS2403: Subsequent variable declarations must have the same type. Variable 'event' must be of type 'CustomEvent<any>', but here has type 'Event'.
node_modules/bluebird/js/release/debuggability.js(166,26): error TS2339: Property 'detail' does not exist on type 'Event'.
node_modules/bluebird/js/release/debuggability.js(476,19): error TS2350: Only a void function can be called with the 'new' keyword.
Expand Down
Loading