Better handling of circular JS containers in getTypeOfVariableOrParameterOrProperty #24732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify getTypeOfVariableOrParameterOrProperty to get the type of the variable declaration before widening it. This essentially avoids some circularities by (1) setting the type of the variable declaration to the unwidened type (2) updating the type of the variable declaration to the widened one. You will still get a circular noImplicitAny in (1), for expressions that actually are circular, but not in (2), for the containers of things that are not themselves circular.
Also make sure to respect the type annotation if there is one.
sandersn
changed the title
This was referenced Jun 11, 2018
weswigham
approved these changes
Jun 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles JS containers specially inside getTypeOfVariableOrParameterOrProperty. Now, instead of delegating to get[Widened]TypeOfVariableLikeDeclaration to get the type of object-literal initializers, it constructs the anonymous type by immediately calling the new getJSInitializerType.
The PR also improves:
var G = m.G = {}, where bothGandm.Ghave special property assignments later in the file.Fixes #24730 and improves the chrome-devtools-frontend baselines.