Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lib.es2018.intl + fix lib.es2017.intl #23785

Merged
merged 2 commits into from
Apr 30, 2018
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,8 @@ const es2017LibrarySourceMap = es2017LibrarySource.map(source =>

const es2018LibrarySource = [
"es2018.regexp.d.ts",
"es2018.promise.d.ts"
"es2018.promise.d.ts",
"es2018.intl.d.ts"
];
const es2018LibrarySourceMap = es2018LibrarySource.map(source =>
({ target: "lib." + source, sources: ["header.d.ts", source] }));
Expand Down
3 changes: 2 additions & 1 deletion Jakefile.js
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,8 @@ var es2017LibrarySourceMap = es2017LibrarySource.map(function (source) {

var es2018LibrarySource = [
"es2018.regexp.d.ts",
"es2018.promise.d.ts"
"es2018.promise.d.ts",
"es2018.intl.d.ts"
];

var es2018LibrarySourceMap = es2018LibrarySource.map(function (source) {
Expand Down
3 changes: 2 additions & 1 deletion lib/lib.es2018.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,5 @@ and limitations under the License.

/// <reference path="lib.es2017.d.ts" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not update the lib files. they are generated as part of the build (jake LKG) and should not be edited manually.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that applies to all files lib\*

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha.. That makes sense.

I had a feeling that was the case when editing the file.. 80,000+ lines!

Would you like me to revert these?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes please.

/// <reference path="lib.es2018.promise.d.ts" />
/// <reference path="lib.es2018.regexp.d.ts" />
/// <reference path="lib.es2018.regexp.d.ts" />
/// <reference path="lib.es2018.intl.d.ts" />
1 change: 1 addition & 0 deletions lib/lib.es2018.full.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ and limitations under the License.
/// <reference path="lib.es2017.d.ts" />
/// <reference path="lib.es2018.promise.d.ts" />
/// <reference path="lib.es2018.regexp.d.ts" />
/// <reference path="lib.es2018.intl.d.ts" />

/////////////////////////////
/// DOM APIs
Expand Down
1 change: 1 addition & 0 deletions lib/tsc.js
Original file line number Diff line number Diff line change
Expand Up @@ -64581,6 +64581,7 @@ var ts;
"es2017.string": "lib.es2017.string.d.ts",
"es2017.intl": "lib.es2017.intl.d.ts",
"es2017.typedarrays": "lib.es2017.typedarrays.d.ts",
"es2018.intl": "lib.es2018.intl.d.ts",
"es2018.promise": "lib.es2018.promise.d.ts",
"es2018.regexp": "lib.es2018.regexp.d.ts",
"esnext.array": "lib.esnext.array.d.ts",
Expand Down
1 change: 1 addition & 0 deletions lib/tsserver.js
Original file line number Diff line number Diff line change
Expand Up @@ -64362,6 +64362,7 @@ var ts;
"es2017.string": "lib.es2017.string.d.ts",
"es2017.intl": "lib.es2017.intl.d.ts",
"es2017.typedarrays": "lib.es2017.typedarrays.d.ts",
"es2018.intl": "lib.es2018.intl.d.ts",
"es2018.promise": "lib.es2018.promise.d.ts",
"es2018.regexp": "lib.es2018.regexp.d.ts",
"esnext.array": "lib.esnext.array.d.ts",
Expand Down
1 change: 1 addition & 0 deletions lib/tsserverlibrary.js
Original file line number Diff line number Diff line change
Expand Up @@ -21252,6 +21252,7 @@ var ts;
"es2017.string": "lib.es2017.string.d.ts",
"es2017.intl": "lib.es2017.intl.d.ts",
"es2017.typedarrays": "lib.es2017.typedarrays.d.ts",
"es2018.intl": "lib.es2018.intl.d.ts",
"es2018.promise": "lib.es2018.promise.d.ts",
"es2018.regexp": "lib.es2018.regexp.d.ts",
"esnext.array": "lib.esnext.array.d.ts",
Expand Down
1 change: 1 addition & 0 deletions lib/typescript.js
Original file line number Diff line number Diff line change
Expand Up @@ -80227,6 +80227,7 @@ var ts;
"es2017.string": "lib.es2017.string.d.ts",
"es2017.intl": "lib.es2017.intl.d.ts",
"es2017.typedarrays": "lib.es2017.typedarrays.d.ts",
"es2018.intl": "lib.es2018.intl.d.ts",
"es2018.promise": "lib.es2018.promise.d.ts",
"es2018.regexp": "lib.es2018.regexp.d.ts",
"esnext.array": "lib.esnext.array.d.ts",
Expand Down
1 change: 1 addition & 0 deletions lib/typescriptServices.js
Original file line number Diff line number Diff line change
Expand Up @@ -80227,6 +80227,7 @@ var ts;
"es2017.string": "lib.es2017.string.d.ts",
"es2017.intl": "lib.es2017.intl.d.ts",
"es2017.typedarrays": "lib.es2017.typedarrays.d.ts",
"es2018.intl": "lib.es2018.intl.d.ts",
"es2018.promise": "lib.es2018.promise.d.ts",
"es2018.regexp": "lib.es2018.regexp.d.ts",
"esnext.array": "lib.esnext.array.d.ts",
Expand Down
1 change: 1 addition & 0 deletions lib/typingsInstaller.js
Original file line number Diff line number Diff line change
Expand Up @@ -16975,6 +16975,7 @@ var ts;
"es2017.string": "lib.es2017.string.d.ts",
"es2017.intl": "lib.es2017.intl.d.ts",
"es2017.typedarrays": "lib.es2017.typedarrays.d.ts",
"es2018.intl": "lib.es2018.intl.d.ts",
"es2018.promise": "lib.es2018.promise.d.ts",
"es2018.regexp": "lib.es2018.regexp.d.ts",
"esnext.array": "lib.esnext.array.d.ts",
Expand Down
Loading