Add prettier user test and fix associated crash #23715
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding
prettier
to the user tests, I uncovered another assert ingetJSDocHost
when looking up type references in a@property
tag inside a@typedef
tag. This PR contains the fix as well as adding prettier to the user tests.Crash
getJSDocHost
didn't work correctly when called on a@property
tag.Incorrect error
Annoying
[]
is still oftennever[]
with strictNullChecks (eg as a property of an object literal, or as the initial value of a reduce)Improved hygiene
@param {number?} n
doesn't make an optional parameter.@param {number} [n]
and@param {number=} n
do.[].concat(x,y,z)
has to be changed to[...x, y, ...z]
Found possible bug
Discussion
As you can see, there were lots of problems adding checkJs to prettier. None of them were particularly difficult to resolve, but there were a lot of small tasks that added up. Without strict null checks, there was only one bug and two hygiene items. Compare that to the whole pile of annoyances and incorrect errors.