Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type lookup rule #22898

Merged
1 commit merged into from
Mar 28, 2018
Merged

fix type lookup rule #22898

1 commit merged into from
Mar 28, 2018

Conversation

Kingwl
Copy link
Contributor

@Kingwl Kingwl commented Mar 27, 2018

Fixes #22825 .

BTW: there are many pr that required review too(

@ajafff
Copy link
Contributor

ajafff commented Mar 27, 2018

Does this also fix the example code snippet in the first comment of the linked issue?

@Kingwl
Copy link
Contributor Author

Kingwl commented Mar 27, 2018

ahhh, i'm not sure that linked issue accept pr and i ignored it

@ajafff
Copy link
Contributor

ajafff commented Mar 27, 2018

According to the comment of @Andy-MS that should also be accepted:

I'll still mark this as a bug because I would expect the second example to have the same behavior regardless of whether you write var foo or let foo inside the function.

mhegazy added a commit that referenced this pull request Mar 28, 2018
@mhegazy mhegazy merged commit 4699c82 into microsoft:master Mar 28, 2018
@ghost ghost merged commit 9b7e5e2 into microsoft:master Mar 28, 2018
@mhegazy
Copy link
Contributor

mhegazy commented Mar 28, 2018

@ajafff I think the issue in #22769 should be handled separately. we should condition the error reporting, and the resolution together.

@Kingwl Kingwl deleted the fix-return-type-lookup-rule branch March 28, 2018 01:14
@microsoft microsoft locked and limited conversation to collaborators Jul 25, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants