Parser analysis and errors for labelled statements, break, continue, return #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Debug.assert(inIterationStatement === ControlBlockContext.CrossingFunctionBoundary | ||
| || inSwitchStatement === ControlBlockContext.CrossingFunctionBoundary); | ||
| grammarErrorAtPos(errorStart, errorLength, Diagnostics.Jump_target_cannot_cross_function_boundary); |
There was a problem hiding this comment.
i'd honestly prefer this was just repeated and htere was no fallthrough above. but up to you.
| return ControlBlockContext.NotNested; | ||
| } | ||
|
|
||
| // TODO(jfreeman): Fill in these stubs |
There was a problem hiding this comment.
Remember to get rid of this now.
|
👍 after feedback is addressed. |
Conflicts: src/compiler/diagnosticInformationMap.generated.ts src/compiler/diagnosticMessages.json src/compiler/parser.ts
JsonFreeman
added a commit
that referenced
this pull request
Jul 25, 2014
Parser analysis and errors for labelled statements, break, continue, return
This was referenced Jul 25, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request covers a couple of things:
I've added a state machine to track labelled statements. It has a current label set for the labels being accumulated, as well as a stack for label sets of enclosing statements. It also tracks whether the enclosing labelled statements are iteration statements or not, because continue statements can only jump to iteration statements.