Update rwc and test262 runner #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else { | ||
| return Harness.userSpecifiedroot + 'tests/baselines/' + type + '/' + fileName; | ||
| return Harness.userSpecifiedroot + baselinefolder + '/' + type + '/' + fileName; |
There was a problem hiding this comment.
I just realized how much of a headache this is going to be. Use path.join.
Really we should be using path.join instead of any string concatenation when possible.
|
👍 |
| if (fs.existsSync(localRwcBaseline)) { | ||
| jake.rmRf(localRwcBaseline); | ||
| } | ||
|
|
||
| jake.mkdirP(localRwcBaseline); | ||
| jake.mkdirP(localTest262Baseline); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are moving test262 and rwc into internal repository.This PR is to update the test262 and rwc path used by the runner