Lexical classification for template strings #1744
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var offset = 0; | ||
| var token = SyntaxKind.Unknown; | ||
| var lastNonTriviaToken = SyntaxKind.Unknown; | ||
| var templateStack: SyntaxKind[]; |
There was a problem hiding this comment.
just initialie this to []
There was a problem hiding this comment.
i think one stack is sufficient. just make sure to clear it every call.
|
@mhegazy @CyrusNajmabadi what are we thinking about this? |
|
It may be too late in our schedule to accept this change for 1.4.2. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds lexical classification support for template strings in the absence of a syntactic classifier.
It will break in the presence of
But otherwise it is a fairly good approximation.