-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added formatToParts to es5.d.ts #15369
Conversation
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
From the internationalization spec: https://tc39.github.io/ecma402/
Based on this i would say these should be added to |
also cc @bterlson for his expert opinion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spoke to @bterlson offline, and he confirmed that the intl is coupled with the ecmascript spec. so i would put these in es2017 instead.
So I was a little bit unsure about this. Is this correct? |
You also need to add it in JakeFile.js |
Now based on current master. Phew... touched quite a few places. Run |
thanks. for future references you do not need to touch files in |
Awesome, thanks. |
Added
Intl.DateTimeFormat.prototype.formatToParts()
toes5.d.ts
. See here.Not sure if tests are mandatory for interface changes?