Parsing and emit for computed properties #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| function parseComputedPropertyName(): ComputedPropertyName { | ||
| var node = <ComputedPropertyName>createNode(SyntaxKind.ComputedPropertyName); | ||
| parseExpected(SyntaxKind.OpenBracketToken); | ||
| node.expression = allowInAnd(parseAssignmentExpression); |
There was a problem hiding this comment.
put a test where "in" is present
There was a problem hiding this comment.
Check for yield, generatorParameter. Add tests as well
|
|
||
| // All callers who expect a value to be returned are in fullTypeCheck mode. | ||
| // If we are not in type check mode, no need to get the type. | ||
| return undefined; |
There was a problem hiding this comment.
Debug.assert(!fullTypeCheck)?
There was a problem hiding this comment.
callers are not in fullTypeCheck, but they don't use the returned value.
There was a problem hiding this comment.
I've rewritten the code so that this function can only be called in fullTypeCheck
JsonFreeman
added a commit
that referenced
this pull request
Nov 27, 2014
Parsing and emit for computed properties
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the plan in issue #1082. The type checker support, .d.ts generation and language service support (other than navigation items). I plan to work on the type system side next.