Use type annotation in declarations emitter #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removed the unnecessary error messages for type alias privacy check
| case SyntaxKind.StringLiteral: | ||
| return writeTextOfNode(type); | ||
| case SyntaxKind.TypeReference: | ||
| return emitTypeReference(<TypeReferenceNode>type); |
There was a problem hiding this comment.
why not just write the text of teh node here? i.e. writeTextOfNode(type)? For that matter, why not just call writeTextOfNode for all TypeNode's?
There was a problem hiding this comment.
that's because we want to format how we are writing d.ts ... We do need to go deep in the type node though to check if it is referencing any type that is not visibile so it didn't seem much of a work writing the text to declaration file along with traversing.
sheetalkamat
added a commit
that referenced
this pull request
Nov 21, 2014
…nsEmitter Use type annotation in declarations emitter
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user specified type annotation exists in the typescript file, use that instead of inferring the name from the symbol