You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
RyanCavanaugh opened this issue
May 5, 2016
· 2 comments
Assignees
Labels
BugA bug in TypeScriptFixedA PR has been merged for this issue@typesRelates to working with .d.ts files (declaration/definition files) from DefinitelyTyped
Module augmentation cannot introduce new names in the top level scope
This error is stopping us from accurately representing UMD-augmenting modules like moment-range. While it's a correct restriction for ES6 values, it's not correct for legacy modules, nor is it a correct restriction for types (e.g. you might want to write an interface in a module augment to provide a type of a new overload parameter)
The text was updated successfully, but these errors were encountered:
RyanCavanaugh
added
Bug
A bug in TypeScript
@types
Relates to working with .d.ts files (declaration/definition files) from DefinitelyTyped
labels
May 5, 2016
Just ran across this while trying to convert to UMD definitions, glad it is fixed. Just wanted to mention too, there is nothing preventing an ES6 module from grabbing a reference to global and augmenting it. For example, this is completely valid:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
BugA bug in TypeScriptFixedA PR has been merged for this issue@typesRelates to working with .d.ts files (declaration/definition files) from DefinitelyTyped
This error is stopping us from accurately representing UMD-augmenting modules like
moment-range
. While it's a correct restriction for ES6 values, it's not correct for legacy modules, nor is it a correct restriction for types (e.g. you might want to write aninterface
in a module augment to provide a type of a new overload parameter)The text was updated successfully, but these errors were encountered: