-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure implement interface quick fix quote type #18169
Labels
Bug
A bug in TypeScript
Fixed
A PR has been merged for this issue
VS Code Tracked
There is a VS Code equivalent to this issue
Milestone
Comments
I would say add a config option for users to choose quote type. in absence of that we can use @rbuckton's inference for imports still. |
Yes I think it makes more sense to have an option in this case. VSCode uses both styles of quotes in its source for example, but only uses double quotes for UI strings |
ghost
mentioned this issue
Dec 11, 2017
ghost
mentioned this issue
Mar 12, 2018
ghost
pushed a commit
that referenced
this issue
Mar 12, 2018
ghost
pushed a commit
that referenced
this issue
Mar 12, 2018
ghost
pushed a commit
that referenced
this issue
Mar 12, 2018
ghost
pushed a commit
that referenced
this issue
Mar 13, 2018
ghost
pushed a commit
that referenced
this issue
Mar 20, 2018
* Support services settings * Code review * More review * Use different names for Options and GetCompletionsAtPositionOptions (todo: come up with better names) * More renames * More renaming * Support quote style in importFixes * Add `importModuleSpecifierPreference` option * Support quote style for `throw new Error('Method not implemented.')` (#18169) * options -> preferences
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Bug
A bug in TypeScript
Fixed
A PR has been merged for this issue
VS Code Tracked
There is a VS Code equivalent to this issue
From microsoft/vscode#33476
TypeScript Version: 2.5.1
Code
Trigger the implement interface quick fix on
class Foo
Expected behavior:
Users can configure if single or double quotes are used for the
Method not implemented error
Actual behavior:
Double quotes are always used for the
Method not implemented error
Related to #13270
The text was updated successfully, but these errors were encountered: