Ensure our readonly emptyArray stays non modified.

microsoft · Feb 26, 2018 · c154b81 · c154b81
1 parent 4f1640d
commit c154b81
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/compiler/factory.ts b/src/compiler/factory.ts
@@ -24,14 +24,14 @@ namespace ts {
      * Make `elements` into a `NodeArray<T>`. If `elements` is `undefined`, returns an empty `NodeArray<T>`.
      */
     export function createNodeArray<T extends Node>(elements?: ReadonlyArray<T>, hasTrailingComma?: boolean): NodeArray<T> {
-        if (elements) {
+        if (!elements || elements === emptyArray) {
+            elements = [];
+        }
+        else {
             if (isNodeArray(elements)) {
                 return elements;
             }
         }
-        else {
-            elements = [];
-        }
 
         const array = <NodeArray<T>>elements;
         array.pos = -1;