🤖 Pick PR #53665 (Fix crash when private id in array ...) into releas…

…e-5.0 (#53677) Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
microsoft · Apr 5, 2023 · 97dac8a · 97dac8a
1 parent b2d5d9b
commit 97dac8a
Show file tree

Hide file tree

Showing 6 changed files with 33 additions and 4 deletions.
diff --git a/src/compiler/transformers/classFields.ts b/src/compiler/transformers/classFields.ts
@@ -2977,11 +2977,11 @@ export function transformClassFields(context: TransformationContext): (x: Source
     }
 
     function visitArrayAssignmentElement(node: Expression): Expression {
-        Debug.assertNode(node, isArrayBindingOrAssignmentElement);
-        if (isSpreadElement(node)) return visitAssignmentRestElement(node);
-        if (!isOmittedExpression(node)) return visitAssignmentElement(node);
+        if (isArrayBindingOrAssignmentElement(node)) {
+            if (isSpreadElement(node)) return visitAssignmentRestElement(node);
+            if (!isOmittedExpression(node)) return visitAssignmentElement(node);
+        }
         return visitEachChild(node, visitor, context);
-
     }
 
     function visitAssignmentProperty(node: PropertyAssignment) {

diff --git a/tests/baselines/reference/parserPrivateIdentifierInArrayAssignment.errors.txt b/tests/baselines/reference/parserPrivateIdentifierInArrayAssignment.errors.txt
@@ -0,0 +1,11 @@
+tests/cases/compiler/parserPrivateIdentifierInArrayAssignment.ts(1,2): error TS2364: The left-hand side of an assignment expression must be a variable or a property access.
+tests/cases/compiler/parserPrivateIdentifierInArrayAssignment.ts(1,8): error TS1109: Expression expected.
+
+
+==== tests/cases/compiler/parserPrivateIdentifierInArrayAssignment.ts (2 errors) ====
+    [#abc]=
+     ~~~~
+!!! error TS2364: The left-hand side of an assignment expression must be a variable or a property access.
+
+!!! error TS1109: Expression expected.
+
diff --git a/tests/baselines/reference/parserPrivateIdentifierInArrayAssignment.js b/tests/baselines/reference/parserPrivateIdentifierInArrayAssignment.js
@@ -0,0 +1,6 @@
+//// [parserPrivateIdentifierInArrayAssignment.ts]
+[#abc]=
+
+
+//// [parserPrivateIdentifierInArrayAssignment.js]
+#abc = [0];
diff --git a/tests/baselines/reference/parserPrivateIdentifierInArrayAssignment.symbols b/tests/baselines/reference/parserPrivateIdentifierInArrayAssignment.symbols
@@ -0,0 +1,4 @@
+=== tests/cases/compiler/parserPrivateIdentifierInArrayAssignment.ts ===
+
+[#abc]=
+
diff --git a/tests/baselines/reference/parserPrivateIdentifierInArrayAssignment.types b/tests/baselines/reference/parserPrivateIdentifierInArrayAssignment.types
@@ -0,0 +1,7 @@
+=== tests/cases/compiler/parserPrivateIdentifierInArrayAssignment.ts ===
+[#abc]=
+>[#abc]= : any
+>[#abc] : [any]
+
+> : any
+
diff --git a/tests/cases/compiler/parserPrivateIdentifierInArrayAssignment.ts b/tests/cases/compiler/parserPrivateIdentifierInArrayAssignment.ts
@@ -0,0 +1 @@
+[#abc]=
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,4 @@
		=== tests/cases/compiler/parserPrivateIdentifierInArrayAssignment.ts ===

		[#abc]=