Fix false error on unresolved import

microsoft · Nov 17, 2023 · 7b2dee6 · 7b2dee6
1 parent 7064af4
commit 7b2dee6
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 0 deletions.
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -45864,6 +45864,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
                 if (!isIllegalExportDefaultInCJS && getIsolatedModules(compilerOptions) && !(sym.flags & SymbolFlags.Value)) {
                     if (
                         sym.flags & SymbolFlags.Alias
+                        && resolveAlias(sym) !== unknownSymbol
                         && getSymbolFlags(sym, /*excludeTypeOnlyMeanings*/ false, /*excludeLocalMeanings*/ true) & SymbolFlags.Type
                         && (!typeOnlyDeclaration || getSourceFileOfNode(typeOnlyDeclaration) !== getSourceFileOfNode(node))
                     ) {

diff --git a/tests/baselines/reference/isolatedModulesExportDeclarationType.errors.txt b/tests/baselines/reference/isolatedModulesExportDeclarationType.errors.txt
@@ -25,4 +25,9 @@
     export default T; // Error
                    ~
 !!! error TS1292: 'T' resolves to a type and must be marked type-only in this file before re-exporting when 'isolatedModules' is enabled. Consider using 'export type { T as default }'.
+
+==== /test4.ts (0 errors) ====
+    // @ts-expect-error
+    import unresolved from "./doesntexist";
+    export default unresolved;
 
diff --git a/tests/baselines/reference/isolatedModulesExportDeclarationType.js b/tests/baselines/reference/isolatedModulesExportDeclarationType.js
@@ -17,6 +17,11 @@ export default T; // Transpiler could assume the alias resolves to a value?
 import { T } from "./type";
 export default T; // Error
 
+//// [test4.ts]
+// @ts-expect-error
+import unresolved from "./doesntexist";
+export default unresolved;
+
 
 //// [type.js]
 "use strict";
@@ -32,3 +37,9 @@ Object.defineProperty(exports, "__esModule", { value: true });
 //// [test3.js]
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+//// [test4.js]
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+// @ts-expect-error
+var doesntexist_1 = require("./doesntexist");
+exports.default = doesntexist_1.default;
diff --git a/tests/cases/compiler/isolatedModulesExportDeclarationType.ts b/tests/cases/compiler/isolatedModulesExportDeclarationType.ts
@@ -17,3 +17,8 @@ export default T; // Transpiler could assume the alias resolves to a value?
 // @Filename: /test3.ts
 import { T } from "./type";
 export default T; // Error
+
+// @Filename: /test4.ts
+// @ts-expect-error
+import unresolved from "./doesntexist";
+export default unresolved;