Fix flow node improper reuse (#60662)

microsoft · Dec 4, 2024 · 6b1ea96 · 6b1ea96
1 parent 9bf5aa7
commit 6b1ea96
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/src/compiler/binder.ts b/src/compiler/binder.ts
@@ -21,6 +21,7 @@ import {
     BreakOrContinueStatement,
     CallChain,
     CallExpression,
+    canHaveFlowNode,
     canHaveLocals,
     canHaveSymbol,
     CaseBlock,
@@ -1104,6 +1105,9 @@ function createBinder(): (file: SourceFile, options: CompilerOptions) => void {
         // and set it before we descend into nodes that could actually be part of an assignment pattern.
         inAssignmentPattern = false;
         if (checkUnreachable(node)) {
+            if (canHaveFlowNode(node) && node.flowNode) {
+                node.flowNode = undefined;
+            }
             bindEachChild(node);
             bindJSDoc(node);
             inAssignmentPattern = saveInAssignmentPattern;

diff --git a/tests/cases/fourslash/unreachableStatementNodeReuse.ts b/tests/cases/fourslash/unreachableStatementNodeReuse.ts
@@ -0,0 +1,13 @@
+/// <reference path="fourslash.ts" />
+
+//// function test() {
+//// 	return/*a*/abc();
+//// 	return;
+//// }
+//// function abc() { }
+
+verify.numberOfErrorsInCurrentFile(1);
+
+goTo.marker("a")
+edit.insert(" ");
+verify.noErrors();