rename sort text helper

microsoft · Mar 23, 2022 · 411bc18 · 411bc18
1 parent 6ebe361
commit 411bc18
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 14 deletions.
diff --git a/src/harness/fourslashInterfaceImpl.ts b/src/harness/fourslashInterfaceImpl.ts
@@ -975,7 +975,7 @@ namespace FourSlashInterface {
                 return `${presetSortText}\0${symbolDisplayName}\0` as SortText;
             },
 
-            AddIsSnippetSuffix(sortText: SortText): SortText {
+            SortBelow(sortText: SortText): SortText {
                 return sortText + "1" as SortText;
             },
         };

diff --git a/src/services/completions.ts b/src/services/completions.ts
@@ -28,7 +28,7 @@ namespace ts.Completions {
             return `${presetSortText}\0${symbolDisplayName}\0` as SortText;
         },
 
-        AddIsSnippetSuffix(sortText: SortText): SortText {
+        SortBelow(sortText: SortText): SortText {
             return sortText + "1" as SortText;
         },
     };
@@ -780,7 +780,7 @@ namespace ts.Completions {
             }
             ({ insertText, isSnippet, importAdder, sourceDisplay } = entry);
             source = CompletionSource.ObjectLiteralMethodSnippet;
-            sortText = SortText.AddIsSnippetSuffix(sortText);
+            sortText = SortText.SortBelow(sortText);
             if (importAdder.hasFixes()) {
                 hasAction = true;
             }

diff --git a/tests/cases/fourslash/completionsObjectLiteralMethod1.ts b/tests/cases/fourslash/completionsObjectLiteralMethod1.ts
@@ -47,7 +47,7 @@ verify.completions({
         },
         {
             name: "bar",
-            sortText: completion.SortText.AddIsSnippetSuffix(
+            sortText: completion.SortText.SortBelow(
                 completion.SortText.ObjectLiteralProperty(completion.SortText.LocationPriority, "bar")),
             source: completion.CompletionSource.ObjectLiteralMethodSnippet,
             insertText: "bar(x: number): void {\n},",
@@ -69,7 +69,7 @@ verify.completions({
         },
         {
             name: "bar",
-            sortText: completion.SortText.AddIsSnippetSuffix(
+            sortText: completion.SortText.SortBelow(
                 completion.SortText.ObjectLiteralProperty(completion.SortText.LocationPriority, "bar")),
             source: completion.CompletionSource.ObjectLiteralMethodSnippet,
             insertText: "bar(x: number): void {\n},",
@@ -81,7 +81,7 @@ verify.completions({
         },
         {
             name: "foo",
-            sortText: completion.SortText.AddIsSnippetSuffix(
+            sortText: completion.SortText.SortBelow(
                 completion.SortText.ObjectLiteralProperty(completion.SortText.LocationPriority, "foo")),
             source: completion.CompletionSource.ObjectLiteralMethodSnippet,
             insertText: "foo(x: string): string {\n},",
@@ -119,7 +119,7 @@ verify.completions({
         },
         {
             name: "\"space bar\"",
-            sortText: completion.SortText.AddIsSnippetSuffix(
+            sortText: completion.SortText.SortBelow(
                 completion.SortText.ObjectLiteralProperty(completion.SortText.LocationPriority, "\"space bar\"")),
             source: completion.CompletionSource.ObjectLiteralMethodSnippet,
             insertText: "\"space bar\"(): string {\n},",
@@ -141,7 +141,7 @@ verify.completions({
         },
         {
             name: "bar",
-            sortText: completion.SortText.AddIsSnippetSuffix(
+            sortText: completion.SortText.SortBelow(
                 completion.SortText.ObjectLiteralProperty(completion.SortText.LocationPriority, "bar")),
             source: completion.CompletionSource.ObjectLiteralMethodSnippet,
             isSnippet: true,

diff --git a/tests/cases/fourslash/completionsObjectLiteralMethod2.ts b/tests/cases/fourslash/completionsObjectLiteralMethod2.ts
@@ -33,7 +33,7 @@ verify.completions({
         },
         {
             name: "foo",
-            sortText: completion.SortText.AddIsSnippetSuffix(
+            sortText: completion.SortText.SortBelow(
                 completion.SortText.ObjectLiteralProperty(completion.SortText.LocationPriority, "foo")),
             source: completion.CompletionSource.ObjectLiteralMethodSnippet,
             insertText: "foo(f: IFoo): void {\n},",

diff --git a/tests/cases/fourslash/completionsObjectLiteralMethod3.ts b/tests/cases/fourslash/completionsObjectLiteralMethod3.ts
@@ -47,7 +47,7 @@ verify.completions({
         },
         {
             name: "M",
-            sortText: completion.SortText.AddIsSnippetSuffix(
+            sortText: completion.SortText.SortBelow(
                 completion.SortText.ObjectLiteralProperty(completion.SortText.LocationPriority, "M")),
             source: completion.CompletionSource.ObjectLiteralMethodSnippet,
             insertText: "M(x: number): void {\n},",
@@ -101,7 +101,7 @@ verify.completions({
         },
         {
             name: "M",
-            sortText: completion.SortText.AddIsSnippetSuffix(
+            sortText: completion.SortText.SortBelow(
                 completion.SortText.ObjectLiteralProperty(completion.SortText.OptionalMember, "M")),
             source: completion.CompletionSource.ObjectLiteralMethodSnippet,
             insertText: "M(x: number): void {\n},",
@@ -113,7 +113,7 @@ verify.completions({
         },
         {
             name: "N",
-            sortText: completion.SortText.AddIsSnippetSuffix(
+            sortText: completion.SortText.SortBelow(
                 completion.SortText.ObjectLiteralProperty(completion.SortText.LocationPriority, "N")),
             source: completion.CompletionSource.ObjectLiteralMethodSnippet,
             insertText: "N(x: string): void {\n},",
@@ -125,7 +125,7 @@ verify.completions({
         },
         {
             name: "O",
-            sortText: completion.SortText.AddIsSnippetSuffix(
+            sortText: completion.SortText.SortBelow(
                 completion.SortText.ObjectLiteralProperty(completion.SortText.OptionalMember, "O")),
             source: completion.CompletionSource.ObjectLiteralMethodSnippet,
             insertText: "O(): void {\n},",

diff --git a/tests/cases/fourslash/fourslash.ts b/tests/cases/fourslash/fourslash.ts
@@ -853,7 +853,7 @@ declare namespace completion {
 
         Deprecated(sortText: SortText): SortText,
         ObjectLiteralProperty(presetSortText: SortText, symbolDisplayName: string): SortText,
-        AddIsSnippetSuffix(sortText: SortText): SortText,
+        SortBelow(sortText: SortText): SortText,
     };
 
     export const enum CompletionSource {