This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add Azure publish support #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@peterblazejewicz any chance you also want to take a look? |
peterblazejewicz
suggested changes
Feb 28, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really enjoy seeing this site now live on the Azure!
👍
src/util/logger.ts
Outdated
@@ -0,0 +1,16 @@ | |||
import * as winston from "winston"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The esModuleInterop: true
has been added to simplify this (and help users)
import winston from "winston"`
:)
src/util/secrets.ts
Outdated
@@ -0,0 +1,26 @@ | |||
import logger from "./logger"; | |||
import * as dotenv from "dotenv"; | |||
import * as fs from "fs"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, the esModuleInterop
is enabled in project to ease migration to TS :)
brittanydrandolph
pushed a commit
that referenced
this pull request
Jun 17, 2022
Add Azure publish support
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is primarily for adding guidance on publishing the app. Notable changes: