Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Update source code to work with express-validator 6.x. Fixes #231 #247

Merged
merged 1 commit into from
Nov 1, 2019
Merged

Update source code to work with express-validator 6.x. Fixes #231 #247

merged 1 commit into from
Nov 1, 2019

Conversation

wildlyinaccurate
Copy link
Contributor

I ran into #231 earlier and fixed it for my own app. I don't know if this is the best way to run the validations, but it was a quick & easy fix.

@msftclas
Copy link

msftclas commented Oct 30, 2019

CLA assistant check
All CLA requirements met.

Copy link
Collaborator

@peterblazejewicz peterblazejewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wildlyinaccurate Thanks for the PR!

LGTM :shipit:

@peterblazejewicz peterblazejewicz changed the title Update source code to work with express-validator 6.x Update source code to work with express-validator 6.x. Fixes #231 Oct 31, 2019
@peterblazejewicz peterblazejewicz merged commit f052852 into microsoft:master Nov 1, 2019
peterblazejewicz added a commit to peterblazejewicz/TypeScript-Node-Starter that referenced this pull request Nov 1, 2019
As the follow-up to the microsoft#247 these are changes that align validation on
the client part with the validation on the backend part:
- min lenght for password (all forms)
- required fields in the profile page form
- reuiqred fields in the contact page form
- autofocus first input within forms

Thanks!
@wildlyinaccurate wildlyinaccurate deleted the fix-express-validation branch November 6, 2019 21:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants