This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Add documentation for environment variables to configure watching of files and directories #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…files and directories Fixes microsoft/TypeScript#25715
mhegazy
reviewed
Jul 24, 2018
pages/Configuring Watch.md
Outdated
| @@ -0,0 +1,30 @@ | |||
| ## Configuring Watch of file and directory | |||
There was a problem hiding this comment.
can you add a link to this page from the compilerOptions page watch section.
mhegazy
reviewed
Jul 24, 2018
pages/Configuring Watch.md
Outdated
| @@ -0,0 +1,30 @@ | |||
| ## Configuring Watch of file and directory | |||
|
|
|||
| `fs.watch` and `fs.watchFile` provided by node, both have pros and cons. | |||
There was a problem hiding this comment.
i would add a heading for this section as Background
There was a problem hiding this comment.
I would start be saying the --watch implementation relies on node's underlying fs.watch/fs.watch file.
There was a problem hiding this comment.
Also consider moving this section to the bottom.
mhegazy
reviewed
Jul 24, 2018
pages/Configuring Watch.md
Outdated
| @@ -0,0 +1,30 @@ | |||
| ## Configuring Watch of file and directory | |||
There was a problem hiding this comment.
do not think you need the header. the page title is sufficient.
mhegazy
approved these changes
Jul 24, 2018
sheetalkamat
force-pushed
the
watchOptions
branch
from
2a49d19 to
bf0e3c2
Compare
alipiry
pushed a commit
to alipiry/TypeScript-Handbook
that referenced
this pull request
Jan 5, 2020
Add documentation for environment variables to configure watching of files and directories
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/TypeScript#25715