Enhance optionalMember function to accept multiple types #2187
Conversation
…arameter and update usage in handleMixinandInterfaces for 'deprecated' property.
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
| } | ||
| }, | ||
| // This is used in the React d.ts files, and not including | ||
| // it would force an update for anyone using React. |
There was a problem hiding this comment.
So this was added in saschanaz#113, back then I accepted it to make things easier, but not sure this is still needed. Can we update React to get their own definition at least? @jakebailey
For deprecated=true, given this is a manual deprecation, we should probably figure out some actual deprecation message than just true.
There was a problem hiding this comment.
I think the react types forward declare this interface, so it may not be that big of a deal to remove. If you send a PR here with your proposed change, I can pull that into a TS PR to check on the extended test suite.
#2053