Skip to content

Toolset update: VS 2022 17.14 Preview 3 #5410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 22, 2025

Conversation

StephanTLavavej
Copy link
Member

@StephanTLavavej StephanTLavavej commented Apr 17, 2025

📜 Changelog

  • Code cleanups:
    • Removed compiler bug workarounds.
  • Infrastructure improvements:
    • Updated dependencies.
      • Updated build compiler to VS 2022 17.14 Preview 3.
      • Updated Python to 3.13.3.

⚙️ Commits

  • Python 3.13.3.
  • New pool.
  • VS 2022 17.14 Preview 3.
  • Remove workarounds for:
  • Change MSVC-internal skips to "likely bogus tests" failures, now that warning C5321 has shipped.
  • Add a compiler version check to CMakeLists.txt.
    • This will detect the common problem of a new contributor using production VS instead of the latest Preview. Because the CMake build is GitHub-only, this check can always be kept up-to-date, unlike the <yvals_core.h> check which is both coarse-grained and often held back by the MSVC-internal toolset.

STL-ASan-CI passed.

@StephanTLavavej StephanTLavavej added the infrastructure Related to repository automation label Apr 17, 2025
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner April 17, 2025 08:42
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Apr 17, 2025
@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in STL Code Reviews Apr 17, 2025
@StephanTLavavej

This comment was marked as resolved.

This comment was marked as resolved.

@StephanTLavavej StephanTLavavej moved this from Final Review to Ready To Merge in STL Code Reviews Apr 17, 2025
@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Apr 22, 2025
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 71ac90c into microsoft:main Apr 22, 2025
39 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews Apr 22, 2025
@StephanTLavavej StephanTLavavej deleted the vs17.14p3 branch April 22, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Related to repository automation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants