<string>: Fix construction and insertion of basic_string with volatile ranges
#5409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
approved these changes
Apr 19, 2025
|
Thanks! 😻 This diff looked a lot scarier than it actually was - just had to deal with the code movement. Please double-check my |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for fixing everyone's favorite cv-qualifier! 😹 🐱 🐈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formerly,
(const) volatile CharTarrays were inconsistently handled in legacy iterator pair functions and new functions added in C++23 WG21-P1206R7. In legacy functions,(const) volatile CharT*were not specially treated due to_Is_elem_cptr, but in P1206R7 functions, they were consistently treated with(const) CharT*due to_Contiguous_range_of.This PR chooses to follow the convention of
_Contiguous_range_ofand changes_Is_elem_cptrto_Is_elem_cvptrto handle(const) volatile CharT*. For volatile contiguous ranges, we need to use non-vectorized element-wise assignment.Fixes #5402.