<regex>: Properly parse dollar anchors in basic and grep mode
#5362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muellerj2
commented
Mar 25, 2025
StephanTLavavej
added
bug
|
Thanks! 😸 I pushed changes to fix product code logic (even though it "can't happen") and various copy-paste relics in the test - please double-check. |
StephanTLavavej
approved these changes
Apr 7, 2025
StephanTLavavej
approved these changes
Apr 7, 2025
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
😻 💵 🤑 |
muellerj2
deleted the
regex-properly-parse-dollar-anchors-in-basic-regexes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides the symmetric change to #5165 for the dollar sign in basic and grep mode. Similar to the handling of the caret anchor, this PR recognizes a dollar sign as an anchor in a basic regular expression if it is at the end of an alternative. It does so by doing a bit of lookahead.
Drive-by: Remove a duplicated test that was accidentally added in #5165.