Skip to content

Remove comments for LWG-3210, LWG-4024, and LWG-4154 #5360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gabrielaugz
Copy link
Contributor

These comments referenced proposed resolutions for LWG-3210, LWG-4024, and LWG-4154, which have now been officially accepted as part of the Working Draft (November 2024 meeting). The implementations were already aligned with the standard, so the references are no longer necessary.

This PR simply removes those comments, with no behavioral changes.

Fixes #5127.

@gabrielaugz gabrielaugz requested a review from a team as a code owner March 25, 2025 18:33
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Mar 25, 2025
@gabrielaugz gabrielaugz force-pushed the remove-lwg-comment-3210-4024-4154 branch from 0f9cc6d to 8c860ff Compare March 25, 2025 18:36
@gabrielaugz
Copy link
Contributor Author

@microsoft-github-policy-service agree

@StephanTLavavej StephanTLavavej self-assigned this Mar 25, 2025
@StephanTLavavej StephanTLavavej added the documentation Related to documentation or comments label Mar 25, 2025
@StephanTLavavej
Copy link
Member

Thanks! Your PR was missing changes for LWG-4024 so I pushed a commit.

@StephanTLavavej StephanTLavavej removed their assignment Mar 25, 2025
@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews Mar 25, 2025
@StephanTLavavej

This comment was marked as resolved.

This comment was marked as resolved.

@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Apr 9, 2025
@StephanTLavavej StephanTLavavej self-assigned this Apr 9, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit d8d672f into microsoft:main Apr 10, 2025
39 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews Apr 10, 2025
@StephanTLavavej
Copy link
Member

Thanks for keeping the STL's comments up to date! This change is expected to ship in VS 18.0 Preview 1. 🎉 🚀 🐱

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation or comments
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Remove comments for LWG-3210, LWG-4024, and LWG-4154
2 participants