-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Casey's accumulated nitpicks #4945
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's make these more consistent with the messages for `find_package(Python)` and the assembler. Showing the path may help folks with problems.
While we're here, let's use `value_type` and `difference_type` where appropriate so we can see which `int` is which.
This test doesn't need `is_permissive.hpp` after microsoft#4914.
These were incorrectly removed by microsoft#4944.
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
assigned StephanTLavavej and CaseyCarter and unassigned StephanTLavavej
Sep 10, 2024
This reverts commit 21835dd.
Change occurrences of "ASAN" in `expected_results.txt` to "ASan", except for the occurrence in an ALLCAPS heading. Drive-by: Change "XFAILs" to "XFAILS" in an ALLCAPS heading.
The deleted default constructor isn't the only feature necessary for a disabled specialization of `formatter`.
The escape hatch variations I think are clear enough and easily searchable, so I removed the comments. I kept the comments in `GH_000431_lex_compare_memcmp_classify`, it's explaining something subtle.
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
approved these changes
Sep 10, 2024
I'm mirroring this to the MSVC-internal repo (if I can chain it to the toolset update without causing problems) - please notify me if any further changes are pushed. |
Thanks for keeping the codebase neat and tidy! 💎 ✨ 😻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor things that aren't worth individual PRs or CIs. These are almost entirely non-functional changes.
find_package(Python)
and the assembler. Showing the path may help folks with problems.element_type
fromContiguousIterator
: While we're here, let's usevalue_type
anddifference_type
where appropriate so we can see whichint
is which.P2163R3_invoke_r
: This test doesn't needis_permissive.hpp
after Adjust tests relying on CWG-1351 noexcept behavior #4914.#endif
comments: These were incorrectly removed by Begin removing EDG workaround fromranges::to
tests #4944.expected_results.txt
comments.formatter
suggesting that a deleted default constructor is sufficient for a disabled specialization.