Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<utility>: Remove self swap check from pair. #4674

Merged
merged 13 commits into from
May 21, 2024
Merged

<utility>: Remove self swap check from pair. #4674

merged 13 commits into from
May 21, 2024

Conversation

Andor233
Copy link
Contributor

Fixes #4597

@Andor233 Andor233 requested a review from a team as a code owner May 13, 2024 13:24
@Andor233
Copy link
Contributor Author

@microsoft-github-policy-service agree

frederick-vs-ja
frederick-vs-ja reviewed May 13, 2024
View reviewed changes
tests/std/tests/GH_004597_self_swap/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/GH_004597_self_swap/test.cpp Outdated Show resolved Hide resolved
stl/inc/utility Show resolved Hide resolved
@frederick-vs-ja

This comment was marked as resolved.

Sign in to view
@StephanTLavavej StephanTLavavej added the bug Something isn't working label May 13, 2024
@StephanTLavavej StephanTLavavej self-assigned this May 13, 2024
frederick-vs-ja
frederick-vs-ja reviewed May 14, 2024
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@frederick-vs-ja frederick-vs-ja mentioned this pull request May 16, 2024
Closed
StephanTLavavej
StephanTLavavej reviewed May 16, 2024
View reviewed changes
tests/std/tests/GH_004597_self_swap/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/GH_004597_self_swap/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/GH_004597_self_swap/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/GH_004597_self_swap/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/GH_004597_self_swap/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/GH_004597_self_swap/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/GH_004597_self_swap/test.cpp Show resolved Hide resolved
tests/std/tests/GH_004597_self_swap/test.cpp Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej removed their assignment May 16, 2024
@StephanTLavavej
Copy link
Member

Thanks, this is awesome! 😻 I pushed a series of fine-grained commits to follow our coding conventions in the test, but nothing serious (beyond a bug number typo).

We merge changes to the GitHub and MSVC-internal repos simultaneously in a semi-manual process. To save time, we merge PRs in batches, and your PR will be part of the next batch. I'll post comments here as I prepare this (likely later this week although possibly next week if I get busy).

@Andor233
Copy link
Contributor Author

Thanks, this is awesome! 😻 I pushed a series of fine-grained commits to follow our coding conventions in the test, but nothing serious (beyond a bug number typo).

We merge changes to the GitHub and MSVC-internal repos simultaneously in a semi-manual process. To save time, we merge PRs in batches, and your PR will be part of the next batch. I'll post comments here as I prepare this (likely later this week although possibly next week if I get busy).

Thank you.

@StephanTLavavej StephanTLavavej self-assigned this May 17, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit c8f45be into microsoft:main May 21, 2024
39 checks passed
@StephanTLavavej
Copy link
Member

Thanks for fixing this bug, and congratulations on your first microsoft/STL commit! 😻 🎉 🪄

This change is expected to ship in VS 2022 17.11 Preview 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederick-vs-ja frederick-vs-ja frederick-vs-ja left review comments

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
bug Something isn't working
Projects
STL Code Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<utility>: Side effects in self-swaps of pair are skipped
3 participants
@Andor233 @frederick-vs-ja @StephanTLavavej