Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use BENCHMARK macro for template benchmarks #4662

Merged
merged 1 commit into from
May 21, 2024
Merged

Use BENCHMARK macro for template benchmarks #4662

merged 1 commit into from
May 21, 2024

Conversation

AlexGuteniev
Copy link
Contributor

See
https://google.github.io/benchmark/user_guide.html#templated-benchmarks

C++11 or newer, you can use the BENCHMARK macro with template parameters:

Related issue #4592

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner May 8, 2024 07:57
@StephanTLavavej StephanTLavavej self-assigned this May 8, 2024
@StephanTLavavej StephanTLavavej added the test Related to test code label May 8, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit a35859c into microsoft:main May 21, 2024
39 checks passed
@StephanTLavavej
Copy link
Member

Thanks for noticing and fixing this inconsistency! 🦅 👁️ 🪄

@AlexGuteniev AlexGuteniev deleted the modernize_std_copy_benchmark branch May 21, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
test Related to test code
Projects
STL Code Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexGuteniev @StephanTLavavej